Re: [Minios-devel] [UNIKRAFT PATCH v3 6/7] arch/arm64: Fix -mfpu=none when not supporting fpsimd

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Justin,

This patch seem fine.

Thanks & Regards
Sharan

Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>

On 4/2/20 6:18 AM, Jia He wrote:
> There is no -mfpu=none compilation flag for gcc on arm. Typically we
> don't disable hw support for fp, merely using -mgeneral-regs-only to
> check it during compilation.
>
> Signed-off-by: Jia He <justin.he@xxxxxxx>
> ---
>   arch/arm/arm64/Makefile.uk | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/arm/arm64/Makefile.uk b/arch/arm/arm64/Makefile.uk
> index af6432c..f77b6df 100644
> --- a/arch/arm/arm64/Makefile.uk
> +++ b/arch/arm/arm64/Makefile.uk
> @@ -9,10 +9,8 @@ else
>   ARCHFLAGS     += -D__ARM_64__ -mgeneral-regs-only
>   endif
>   
> -ISR_ARCHFLAGS += -D__ARM_64__ -mgeneral-regs-only
> -
>   # Disable FPU for trap/exception/interrupt handlers
> -ISR_ARCHFLAGS += -mfpu=none
> +ISR_ARCHFLAGS += -D__ARM_64__ -mgeneral-regs-only
>   
>   CINCLUDES   += -I$(CONFIG_UK_BASE)/arch/arm/arm64/include
>   ASINCLUDES  += -I$(CONFIG_UK_BASE)/arch/arm/arm64/include
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel