Re: [Minios-devel] [UNIKRAFT PATCH v3 7/7] build: Add 'isr' variant for arm64 kvm plat source files called within irq context

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Justin,

This patch is fine.

Thanks & Regards

Sharan

Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>

On 4/2/20 6:18 AM, Jia He wrote:
> 'isr' variant is to be called within interrupt safe context. Typically,
> traps/exception/context-switch need to be added this variant.
> On arm, -mgeneral-regs-only is passed to forbid the compiler to use enhanced
> CPU functions that are not saved within interrupt context (e.g., floating
> point units, vector units).
>
> Signed-off-by: Jia He <justin.he@xxxxxxx>
> ---
>   plat/kvm/Makefile.uk | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/plat/kvm/Makefile.uk b/plat/kvm/Makefile.uk
> index a6d6f5e..260940a 100644
> --- a/plat/kvm/Makefile.uk
> +++ b/plat/kvm/Makefile.uk
> @@ -82,16 +82,16 @@ LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += 
> $(UK_PLAT_COMMON_BASE)/arm/cache64.S|co
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += 
> $(UK_PLAT_COMMON_BASE)/arm/psci_arm64.S|common
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += 
> $(UK_PLAT_COMMON_BASE)/arm/time.c|common
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += 
> $(UK_PLAT_COMMON_BASE)/arm/generic_timer.c|common
> -LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += 
> $(UK_PLAT_COMMON_BASE)/arm/traps.c|common
> +LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += $(UK_PLAT_COMMON_BASE)/arm/traps.c|isr
>   ifeq ($(CONFIG_HAVE_SCHED),y)
> -LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += 
> $(UK_PLAT_COMMON_BASE)/arm/thread_start64.S|common
> +LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += 
> $(UK_PLAT_COMMON_BASE)/arm/thread_start64.S|isr
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += 
> $(UK_PLAT_COMMON_BASE)/thread.c|common
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += 
> $(UK_PLAT_COMMON_BASE)/sw_ctx.c|common
>   endif
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += $(LIBKVMPLAT_BASE)/arm/memory.c|arm
> -LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += $(LIBKVMPLAT_BASE)/arm/entry64.S
> -LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += $(LIBKVMPLAT_BASE)/arm/exceptions.S
> -LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += $(LIBKVMPLAT_BASE)/arm/pagetable64.S
> +LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += $(LIBKVMPLAT_BASE)/arm/entry64.S|isr
> +LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += 
> $(LIBKVMPLAT_BASE)/arm/exceptions.S|isr
> +LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += 
> $(LIBKVMPLAT_BASE)/arm/pagetable64.S|isr
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += $(LIBKVMPLAT_BASE)/arm/setup.c
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += $(LIBKVMPLAT_BASE)/arm/lcpu.c
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += $(LIBKVMPLAT_BASE)/arm/intctrl.c
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel