Re: [PATCH] mini-os: Use a single start_info_ptr variable

[Costin Lupu <costin.lupu@xxxxxxxxx>]

On 8/18/20 7:43 PM, Samuel Thibault wrote:
> Costin Lupu, le mar. 18 août 2020 16:42:22 +0300, a ecrit:
>>  arch/x86/setup.c | 2 +-
>>  shutdown.c       | 4 ++--
> 
> This would break the arm build, which does not have the start_info_ptr
> variable. That being said, shutdown.c doesn't seem like buildable on
> arm. I'd say not try to touch this code, and wait for ARM porters to fix
> the start_info question, and then we can see how to factorize the
> variables.
> 

Oops, my bad. :(

I guess we should move it to an arch-independent file. One example is
kernel.c where we have a similar scenario for `cmdline`, which is also
set in `arch/x86/setup.c`. And in `init_shutdown` it would be set only
if it wasn't set before, i.e. start_info_ptr == 0 (which would happen
for ARM), or otherwise we would check that `si` parameter has the same
value as `start_info_ptr` (which would happen for x86).

If this is ok with you then I can prepare a patch.

Cheers,
Costin