[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH] mini-os: Use a single start_info_ptr variable
Costin Lupu, le mer. 19 août 2020 16:01:18 +0300, a ecrit: > I guess we should move it to an arch-independent file. One example is > kernel.c where we have a similar scenario for `cmdline`, which is also > set in `arch/x86/setup.c`. Indeed. > And in `init_shutdown` it would be set only > if it wasn't set before, i.e. start_info_ptr == 0 (which would happen > for ARM), or otherwise we would check that `si` parameter has the same > value as `start_info_ptr` (which would happen for x86). I would say not to bother setting it again. You can actually remove the parameter of init_shutdown, and of start_kernel as well. 892b661de6d79a768eb7def9489a80f0c7289f42 added, but without taking care of arm. Arm porters will have to fix the HYPERVISOR_suspend() call anyway, and possibly they don't even need start_info_ptr in their case, so letting it to be NULL will be fine, if arm needs it at some point, they will set it up in their setup.c Samuel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |