Re: [UNIKRAFT PATCH 1/3] build: Use -fno-PIC instead of -no-pie as compilation flag

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Thanks a lot!

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 23.03.20 09:25, Razvan Deaconescu wrote:
> -no-pie is used as a linking option to disable PIE (Position Independent
> Executable). -fno-PIC is used for compilation (COMPFLAGS).
>
> Signed-off-by: Razvan Deaconescu <razvan.deaconescu@xxxxxxxxx>
> ---
>   Makefile.uk | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.uk b/Makefile.uk
> index a78afc0..7527f0f 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -52,6 +52,6 @@ M4FLAGS      += -DUK_VERSION=$(UK_VERSION).$(UK_SUBVERSION)
>   # If GCC supports "-no-pie" flag, we will add this flag to link flags to
>   # override "pie" option, because some distributions will set
>   # "--enable-default-pie" by default.
> -COMPFLAGS-$(call gcc_version_ge,6,1)   += -no-pie
> +COMPFLAGS-$(call gcc_version_ge,6,1)   += -fno-PIC
>   LIBLDFLAGS-$(call gcc_version_ge,6,1) += -no-pie
>   LDFLAGS-$(call gcc_version_ge,6,1)    += -no-pie