Re: [UNIKRAFT PATCH 2/3] build: Remove --omagic flag from LIBLDFLAGS

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 23.03.20 09:25, Razvan Deaconescu wrote:
> The --omagic flag is required for the final linking step, as part of
> LDFLAGS.
>
> Signed-off-by: Razvan Deaconescu <razvan.deaconescu@xxxxxxxxx>
> ---
>   Makefile.uk | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile.uk b/Makefile.uk
> index 7527f0f..75adc92 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -18,10 +18,11 @@ CINCLUDES    += -I$(CONFIG_UK_BASE)/include
>   CXXINCLUDES  += -I$(CONFIG_UK_BASE)/include
>   GOCINCLUDES  += -I$(CONFIG_UK_BASE)/include
>   
> +LIBLDFLAGS  += -nostdinc -nostdlib -Wl,-r -Wl,-d -Wl,--build-id=none
> +
>   # Set the text and data sections to be readable and writable. Also,
>   # do not page-align the data segment. If the output format supports
>   # Unix style magic numbers, mark the output as OMAGIC.
> -LIBLDFLAGS  += -nostdinc -nostdlib -Wl,--omagic -Wl,-r -Wl,-d 
> -Wl,--build-id=none
>   LDFLAGS     += -nostdinc -nostdlib -Wl,--omagic -Wl,--build-id=none
>   
>   COMPFLAGS-$(CONFIG_OPTIMIZE_NONE)         += -O0 -fno-optimize-sibling-calls -fno-tree-vectorize