Re: [UNIKRAFT PATCH v2 0/7] lib/ukblkdev: Minor API improvements and fixes

[Laurentiu Barbulescu <lrbarbulescu@xxxxxxxxx>]

Hi Simon,

Thanks for updating this patch series.
It looks good to me and I will mark the patches as reviewed.

Best wishes,
Laurentiu

On Tue, Dec 22, 2020 at 5:38 PM Simon Kuenzer <simon.kuenzer@xxxxxxxxx> wrote:

This series consists of a number of minor improvements and
fixes of the ukblkdev API. This is mainly done to inline
the ukblkdev API with the uknetdev API.

Changes v2:
 - Remove including <uk/arch/types.h> in <uk/blkreq.h>
 - Adapt API documentation in <uk/blkdev.h> to reflect
   `uk_blkdev_queue_configure()`

Simon Kuenzer (7):
  lib/ukblkdev: blkdev.h: Include <uk/assert.h>
  lib/ukblkdev: blkreq.h: Include <uk/arch/atomic.h>
  lib/ukblkdev: blkreq.h: Use typedef for __sector
  lib/ukblkdev: blkreq.h: Use UK_BLKREQ_ prefix for states and ops
  lib/ukblkdev: API refactoring: `uk_blkdev_queue_configure()`
  lib/ukblkdev: Provide `uk_blkdev_size()`
  lib/ukblkdev: blkdev.h: Description about interrupts

 lib/ukblkdev/blkdev.c                   | 16 +++++++--------
 lib/ukblkdev/exportsyms.uk              |  2 +-
 lib/ukblkdev/include/uk/blkdev.h        | 27 +++++++++++++++----------
 lib/ukblkdev/include/uk/blkdev_core.h   |  6 +++---
 lib/ukblkdev/include/uk/blkdev_driver.h |  2 +-
 lib/ukblkdev/include/uk/blkreq.h        | 20 ++++++++++--------
 plat/drivers/virtio/virtio_blk.c        | 16 +++++++--------
 plat/xen/drivers/blk/blkfront.c         | 14 ++++++-------
 8 files changed, 56 insertions(+), 47 deletions(-)

--
2.20.1