Re: [UNIKRAFT PATCH v2 7/7] lib/ukblkdev: blkdev.h: Description about interrupts

[Laurentiu Barbulescu <lrbarbulescu@xxxxxxxxx>]

Hi Simon,

Looks good to me.

Reviewed-by: Laurentiu Barbulescu <lrbarbulescu@xxxxxxxxx>

On Tue, Dec 22, 2020 at 5:38 PM Simon Kuenzer <simon.kuenzer@xxxxxxxxx> wrote:

Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
---
 lib/ukblkdev/include/uk/blkdev.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/ukblkdev/include/uk/blkdev.h b/lib/ukblkdev/include/uk/blkdev.h
index 1861bb3b7..3e42eb98a 100644
--- a/lib/ukblkdev/include/uk/blkdev.h
+++ b/lib/ukblkdev/include/uk/blkdev.h
@@ -413,7 +413,8 @@ int uk_blkdev_queue_submit_one(struct uk_blkdev *dev, uint16_t queue_id,
                                             | UK_BLKDEV_STATUS_MORE))

 /**
- * Get responses from the queue
+ * Get responses from the queue and re-enable interrupts on the target queue
+ * when they were enabled before.
  *
  * @param dev
  *     The Unikraft Block Device
--
2.20.1