[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/7] Mini-OS: add support for runtime mounts
- To: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, minios-devel@xxxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, wl@xxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 10 Feb 2023 18:51:08 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=10Y/pN9zzZyq5FpSK5ush7e+XYwTwTQ2g3oGNW5huOo=; b=SDtIz9hTnZA68F9N0G+Skxsboubl9QpFFNuzcC7pv28u8Q8bt+UEGHOO1TLawGIghPvEaWc2MbZKfULUzmw3tCt+caCq+B0OJZrVVHkru9j/nkggV2s8tNKHE/PVwkvrOS4jRqXqJs0vEaAUq2uoNx+8ZZc68ofLoDs+aax0zcQQoYS2FngDJQ6NJHjGRxj2CCgEz2XV1erKPzgr79Z/n5uqwNG3Gt+DADIBGsrNzuX/062cBkGtjkf9fUrq3vp8jWQkE2Wd4aaHPRKOC8grR6dc8Tce7t+vjW9fi5IKiykp+3N68rAak0ecBIrXeSFr3PaM2E8kU87EdFJESONAIA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OmCvKihCI5SbN3jPyoIdzBkPvDLOk+lsadJORRbKzZSo1ct7vmNDuwwZS59JkdhjEK4JgNVtzyvpn6q3LeheYl2QAqWFLHuLdzS99nP/fyIPE6iN/OioLyWYXV8ryfGsAGiqyVZcrQO9AE8W/58FuzZs7Hy1BS9apP57Yt/Ekw1q7aXXnSTMtQcV5wL0ZNYBd2VRrc01QzEPzq4KEa0OKHEbTcmeogdzgW1Vaw2rnx7Ih7L1oZJuKo4kKpYGtMg7riHzZfD2Tm3FrtyCTTgIbJ/w0cJsVmqKJuYXYHDv6VT32/DhyfrM2SxoL2M0gI37xPgL2D9JBPrGiTmfit+bQQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Delivery-date: Fri, 10 Feb 2023 18:51:26 +0000
- Ironport-data: A9a23:+Xst4KgpTrO0z73uRLidXS3AX161gxEKZh0ujC45NGQN5FlHY01je htvDWjQbP+IYTfxf9onYdu2o0JUvcXWmtMwTgplrH0xF3wb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWt0N8klgZmP6sT5gaGzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQDczEubA6EhN6P4+3iErR+vfoYB+z0adZ3VnFIlVk1DN4AaLWaGeDmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEgluGybbI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6RePkpqU70AH7Kmo7EwwGDH6n+fKD2xCmfM9Fb FEG93Unov1nnKCsZpynN/Gim1aftxsBVt4WD+074giQzrb87gCCQ2wVSTgHb8Yp3Oc0SiYtz UShhM7yCHpkt7j9YXec8LaTtna+NDYYKUcGZDQYVk0V7t/7uoYxgxnTCNF5H8adntDzXD393 T2OhCw/nKkIy94G0b2h+lLKiC7qoYLGJiYq4i3HU2Tj6Rl2DLNJfKSt4FnfqPpFcoCQSwDbu GBewpfDqucTEZuKiSqBBv0XG62k7OqENzuahkNzG54m9HKm/HvLkZ1s3QyS7XxBaq4sEQIFq meK0e+NzPe/5EeXUJI=
- Ironport-hdrordr: A9a23:8/RnG6DFK9TNNcHlHeko55DYdb4zR+YMi2TDGXoBLCC9Ffbo6v xG+c516faaskd3ZJhNo6HiBEDEewKlyXc32/hkAV7AZnidhILXFvAF0WK4+UyUJ8SWzIc0vs 0MH8YeaOEYT2IK9voSizPId+rIruP3kpyAtKP+9lsodytOApsQkTuRcjzra3FedU1jDZo9FJ 2Tou9GvSfIQwVhUu2LQkAfWe7NvtvKk4+jTyInKnccmXWzpALt0aX9FReA2BcYTndo+pcNtU b4syGR3NTdjxmcoiWsp1M7K64m6ecJ0uEzdvBklPJlWQnRtg==
- List-id: Mini-os development list <minios-devel.lists.xenproject.org>
On 10/02/2023 12:44 pm, Samuel Thibault wrote:
> Juergen Gross, le ven. 10 févr. 2023 13:14:20 +0100, a ecrit:
>> On 10.02.23 12:43, Andrew Cooper wrote:
>>> On 10/02/2023 10:46 am, Juergen Gross wrote:
>>>> diff --git a/lib/sys.c b/lib/sys.c
>>>> index 2f33c937..dc8a8c69 100644
>>>> --- a/lib/sys.c
>>>> +++ b/lib/sys.c
>>>> @@ -339,7 +339,14 @@ static int open_mem(struct mount_point *mnt, const
>>>> char *pathname, int flags,
>>>> return fd;
>>>> }
>>>> -static struct mount_point mount_points[] = {
>>>> +#ifdef CONFIG_CONSFRONT
>>>> +#define STATIC_MNTS 4
>>>> +#else
>>>> +#define STATIC_MNTS 2
>>>> +#endif
>>> This ought to be
>>>
>>> #define STATIC_MNTS (2 + (IS_ENABLED(CONFIG_CONSFRONT) * 2))
>>>
>>> because it shows where the parts come from, and is much cleaner to add a
>>> 3rd one to in due course.
>> In principle fine, but I'm not sure it is worth the effort to add
>> IS_ENABLED() support to Mini-OS.
>>
>>> That said, it would be simpler to just have a total mounts set at 16 or
>>> so? Does a difference of two dynamic mounts depending on CONSFRONT
>>> actually matter?
>> Probably not. Samuel, any thoughts on that?
> We can probably as well just have 16 mount entries indeed.
I'm happy to fix that up on commit if it's the only other issue in this
patch.
~Andrew
|
