[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: sockets exn- one day i'll learn to put things down

  • To: Anil Madhavapeddy <anil@xxxxxxxxxx>
  • From: Richard Mortier <Richard.Mortier@xxxxxxxxxxxxxxxx>
  • Date: Sat, 5 Nov 2011 08:46:38 +0000
  • Accept-language: en-US, en-GB
  • Acceptlanguage: en-US, en-GB
  • Cc: Mirage List <cl-mirage@xxxxxxxxxxxxxxx>
  • List-id: MirageOS development <cl-mirage.lists.cam.ac.uk>
  • Thread-index: Acybl5cr70FkBMx8Qoir6BK6ZMKizA==
  • Thread-topic: sockets exn- one day i'll learn to put things down

On 5 Nov 2011, at 00:04, Anil Madhavapeddy wrote:

> The try/catch would need to go locally here; can you try
> let close t =
>  R.close t.fd;
>  (try Lwt.wakeup t.abort_u () with _ -> ());
>  return ()
> This should make multiple close() calls safe.

done- pull req sent, both for this fix and modifications to enable turning 
on/off lwt-debug.

seems to fix the crashes i've been observing, which is nice :)  though i'm 
still a little disconcerted as to what was actually causing it- the debug 
output i had in place suggested it wasn't getting called twice due to the exn 
handler.  (but that might be my debug output coming out in an unexpected order.)

anyway- back to content production i guess ;)


i apologise for the rather long and pointless legalese that usually follows - i 
have no control over this. it embarrasses me as much as it irritates you...

This message and any attachment are intended solely for the addressee and may 
contain confidential information. If you have received this message in error, 
please send it back to me, and immediately delete it.   Please do not use, copy 
or disclose the information contained in this message or in any attachment.  
Any views or opinions expressed by the author of this email do not necessarily 
reflect the views of the University of Nottingham.

This message has been checked for viruses but the contents of an attachment
may still contain software viruses which could damage your computer system:
you are advised to perform your own checks. Email communications with the
University of Nottingham may be monitored as permitted by UK legislation.



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.