Re: [MirageOS-devel] TCP checksum offload with Xen

[Thomas Gazagnaire <thomas@xxxxxxxxxxxxxx>]

>> Looks good -- since V2.mli isn't tagged yet, this can just extend the call
>> to `write` instead of having a `write2`.
> 
> I actually tried that first, but it makes V1 incompatible with V2
> which complicates things a bit. As it is, if you have a V2 module you
> can use it with anything that wants a V1 type, which makes upgrading
> easier.

I'm not too worry about that, as we need to fix the error type definition at 
one point as well (and the FS module type)

>> However, would it be better to
>> define an interface flags type in `NETWORK`, and just let the `write` call
>> supply a list of flags?  That would permit easier extension to other
>> offloads in the future.
> 
> Yes, probably. Should the flags type be abstract?

A possibility might be to define a record 'flag' with at least one field called 
"checksum". Not sure too much abstraction is a good thing here.

Thomas


>> A pull request to mirage/mirage of the WIP patches would be good to track
>> this in the issue tracker.
> 
> Done:
> 
> https://github.com/mirage/mirage/pull/286
> 
> 
> -- 
> Dr Thomas Leonard        http://0install.net/
> GPG: 9242 9807 C985 3C07 44A6  8B9A AE07 8280 59A5 3CC1
> GPG: DA98 25AE CAD0 8975 7CDA  BD8E 0713 3F96 CA74 D8BA
> 
> _______________________________________________
> MirageOS-devel mailing list
> MirageOS-devel@xxxxxxxxxxxxxxxxxxxx
> http://lists.xenproject.org/cgi-bin/mailman/listinfo/mirageos-devel


_______________________________________________
MirageOS-devel mailing list
MirageOS-devel@xxxxxxxxxxxxxxxxxxxx
http://lists.xenproject.org/cgi-bin/mailman/listinfo/mirageos-devel