[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MirageOS-devel] TCP checksum offload with Xen

On 19 Aug 2014, at 14:26, Thomas Gazagnaire <thomas@xxxxxxxxxxxxxx> wrote:

>>> Looks good -- since V2.mli isn't tagged yet, this can just extend the call
>>> to `write` instead of having a `write2`.
>> I actually tried that first, but it makes V1 incompatible with V2
>> which complicates things a bit. As it is, if you have a V2 module you
>> can use it with anything that wants a V1 type, which makes upgrading
>> easier.
> I'm not too worry about that, as we need to fix the error type definition at 
> one point as well (and the FS module type)
>>> However, would it be better to
>>> define an interface flags type in `NETWORK`, and just let the `write` call
>>> supply a list of flags?  That would permit easier extension to other
>>> offloads in the future.
>> Yes, probably. Should the flags type be abstract?
> A possibility might be to define a record 'flag' with at least one field 
> called "checksum". Not sure too much abstraction is a good thing here.

Agreed on both counts...

MirageOS-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.