Re: [MirageOS-devel] github xen git mirror

[Thomas Leonard <talex5@xxxxxxxxx>]

On 4 August 2015 at 14:14, Luke Dunstan <lukedunstan81@xxxxxxxxx> wrote:
>
>
> On Mon, 3 Aug 2015 at 21:27 Thomas Leonard <talex5@xxxxxxxxx> wrote:
>>
>> On 30 July 2015 at 16:16, Anil Madhavapeddy <anil@xxxxxxxxxx> wrote:
>> >
>> > On 30 Jul 2015, at 16:13, Luke Dunstan <lukedunstan81@xxxxxxxxx> wrote:
>> >
>> >
>> > On the normal Trusty cubieboard2 image I can install minios-xen fine,
>> > but on
>> > Vivid I get an error:
>> >
>> > $ opam install minios-xen
>> >
>> > [ERROR] The compilation of minios-xen failed at "make debug=n".
>> > ...
>> >  ### stderr ###
>> > # dtc/libfdt/fdt_ro.c:453:6: error: ânodedepthâ may be used
>> > uninitialized in
>> > this function [-Werror=maybe-uninitialized]
>> > # [...]
>> > # /home/mirage/.opam/4.02.1/build/minios-xen.0.7/include/libfdt.h: In
>> > function âfdt_parent_offsetâ:
>> > # dtc/libfdt/fdt_ro.c:468:9: error: ânodedepthâ may be used
>> > uninitialized in
>> > this function [-Werror=maybe-uninitialized]
>> > #   return fdt_supernode_atdepth_offset(fdt, nodeoffset,
>> > #          ^
>> > # dtc/libfdt/fdt_ro.c:453:6: note: ânodedepthâ was declared here
>> > #   int nodedepth;
>> > #       ^
>> > # cc1: all warnings being treated as errors
>> > # make: ***
>> > [/home/mirage/.opam/4.02.1/build/minios-xen.0.7/dtc/libfdt/fdt_ro.o]
>> > Error 1
>> >
>> > mirage-xen-minios.0.7.0 was OK because of:
>> >
>> >
>> > https://github.com/talex5/xen/commit/804d40b4fe00d68e1be3160f8bcc0d94f3d4edf0
>> >
>> > I'm guessing that the difference in this image is that it has GCC-4.9.2
>> > instead of 4.8.x, but I'm not certain.
>> >
>> >
>> > Could we turn off -Werror for the OPAM builds, Thomas?  It's only really
>> > useful on Travis or other CI builds to spot regressions, but quite a
>> > blocker
>> > when using a varied build toolchain.
>>
>> It was hard-coded into Mini-OS's build system. I've removed it, and
>> added a $TRAVIS_CFLAGS so we can still use it for CI.
>
>
> Thanks, it works fine now. For the record though, this doesn't work:
>
> $ opam pin add minios-xen https://github.com/talex5/mini-os.git
>
> because opam pin does not support Git submodules:
> https://github.com/ocaml/opam/issues/1422
>
> It's easy to work around:
>
> $ git clone --recursive https://github.com/talex5/mini-os.git
> $ opam pin add minios-xen mini-os

The Xen people complained about using submodules too, so I'll just
copy it in instead.


-- 
Dr Thomas Leonard        http://roscidus.com/blog/
GPG: DA98 25AE CAD0 8975 7CDA  BD8E 0713 3F96 CA74 D8BA

_______________________________________________
MirageOS-devel mailing list
MirageOS-devel@xxxxxxxxxxxxxxxxxxxx
http://lists.xenproject.org/cgi-bin/mailman/listinfo/mirageos-devel