Re: [MirageOS-devel] Solo5 renaming and OPAM package names

[Hannes Mehnert <hannes@xxxxxxxxxxx>]

hey,

On 27/08/2018 16:38, Martin Lucina wrote:
> On Friday, 24.08.2018 at 19:05, Hannes Mehnert wrote:
>> sounds about right!
> 
> Your reply did not go to the list, adding it back in Cc:.

oh, sorry.

>> On 24/08/2018 16:57, Martin Lucina wrote:
>> in the mirage utility itself, there are various references to
>> solo5-kernel-* which need adjustment
> 
> Yes, I'll do those.
> 
> However, I'm not sure that just making ocaml-freestanding and mirage-solo5
> depend on the new solo5-bindings-* packages instead of solo5-kernel-* is
> sufficient. Having just experimented with some pins, this can result in a
> situation where (e.g. if downgrading via a pin) ocaml-freestanding and
> mirage-solo5 get out of sync.
> 
> I'm not sure what the best way to prevent that happening is. Making
> mirage-solo5 (the new 0.4.0+) conflict with solo5-kernel-* and mirage-solo5
> (all currently published versions) conflict with solo5-bindings-* seems
> like a rather roundabout way to accomplish this?

that sounds fine to me.

>>> Regarding user-visible changes to the mirage front-end tool itself, I would
>>> like to rename the "ukvm" target to "vt", while keeping "ukvm" (with a
>>> warning) as a backward-compatible alias for "vt".
>>
>> that sounds reasonable to me.
> 
> Unclear if the "backward compatible alias" can be done in Functoria w/o
> keeping both Ukvm and Vt as allowed values for the "mode" key and thus
> listed *everywhere* in the match clauses throughout mirage.ml. Any ideas on
> how to accomplish this?

I can think of two ways: (a) either not providing a backward compatible
alias (and update instructions everywhere - this has the advantage that
we don't need to decide when to remove this option ;), or (b) put both
"vt" and "ukvm" into the target_conv enum in mirage_key.ml (pointing to
the same value) -- the parser is fine with this, the printer takes the
last mention (due to using List.assoc on the List.rev_map):

--- a/lib/mirage_key.ml
+++ b/lib/mirage_key.ml
@@ -98,6 +98,7 @@ let target_conv: mode Cmdliner.Arg.converter =
     "xen"   , `Xen;
     "virtio", `Virtio;
     "ukvm"  , `Ukvm;
+    "vt"    , `Ukvm;
     "muen"  , `Muen;
     "qubes" , `Qubes
   ]

I prefer (a), although I'll misspell this option for quite some time ;)


hannes

_______________________________________________
MirageOS-devel mailing list
MirageOS-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/mirageos-devel