[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[MirageOS-devel] HEADSUP: changes in module type IP (mirage-protocols{-lwt}) to be merged Monday Sep 3rd


while debugging an IPv4 issue, and reading through MirageOS code, I
found some leftover type aliases (namely ethif, prefix) which are no
longer needed in the IP module type.  AFAICT, they used to be part of
the `connect` signature, which is no longer part of the module type.

I went through mirage-protocols{-lwt} and all the users I could find to
remove them (since I like to remove unnecessary boilerplate code ;)).
The changes compile and run fine (there are some pins required since the
CI cross-references other libraries, and builds reverse dependencies).

Please have a look at the following PRs:
- https://github.com/mirage/mirage-protocols/pull/11
- https://github.com/mirage/mirage-tcpip/pull/371
- https://github.com/mirage/charrua-core/pull/83
- https://github.com/mirage/mirage-qubes/pull/24

And let me know if you wish to retain the types as is (if so, please
tell why), and/or let me know if you're aware of any other
implementations of IP which may need to be adapted (vpnkit is built as a
reverse dependency of mirage-protocols by travis, and works fine with
the changes).

Thomas Gazagnaire already approved the first PR, if nobody objects, I'll
merge the above mentioned PRs on _Monday, Sep 3rd_ and draft releases of
the affected libraries, and also add upper bounds to the versions
already in opam-repository to not use newer mirage-protocols.

I'd propose to stick to semantic versioning in this case and would
release a mirage-protocols{-lwt}.2.0.0.

Thanks for reading,


MirageOS-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.