[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[win-pv-devel] [PATCH] Remove S4 BUG_ONs for interface that don't depend on Xen



Some interfaces don't depend on Xen (e.g. CACHE, RANGE_SET) and so it
is safe for them to have outstanding references across an S4 transtion
or suspend/resume (i.e. transitions which result in a new domain). Only
interfaces that actually depend on Xen (e.g. GNTTAB, EVTCHN) cannot
have outstanding reference in these cases, so limit the BUG_ONs to those.

Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
---
 src/xenbus/fdo.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/xenbus/fdo.c b/src/xenbus/fdo.c
index 34aee14..2e1ef6b 100644
--- a/src/xenbus/fdo.c
+++ b/src/xenbus/fdo.c
@@ -3219,12 +3219,8 @@ FdoS3ToS4(
     BUG_ON(SuspendGetReferences(Fdo->SuspendContext) != 0);
     BUG_ON(SharedInfoGetReferences(Fdo->SharedInfoContext) != 0);
     BUG_ON(EvtchnGetReferences(Fdo->EvtchnContext) != 0);
-    BUG_ON(DebugGetReferences(Fdo->DebugContext) != 0);
     BUG_ON(StoreGetReferences(Fdo->StoreContext) != 0);
-    BUG_ON(RangeSetGetReferences(Fdo->RangeSetContext) != 0);
-    BUG_ON(CacheGetReferences(Fdo->CacheContext) != 0);
     BUG_ON(GnttabGetReferences(Fdo->GnttabContext) != 0);
-    BUG_ON(UnplugGetReferences(Fdo->UnplugContext) != 0);
     BUG_ON(BalloonGetReferences(Fdo->BalloonContext) != 0);
 
 not_active:
-- 
2.5.3


_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.