Re: [win-pv-devel] [PATCH 2/2] Reduce severity of some debug messages

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel [mailto:win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx] On
> Behalf Of owen.smith@xxxxxxxxxx
> Sent: 22 November 2016 13:44
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> Subject: [win-pv-devel] [PATCH 2/2] Reduce severity of some debug
> messages
> 
> From: Owen Smith <owen.smith@xxxxxxxxxx>
> 
> Error and Warning were used for Info level messages
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

Acked-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

> ---
>  src/xeniface/fdo.c | 6 +++---
>  src/xeniface/wmi.c | 6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/src/xeniface/fdo.c b/src/xeniface/fdo.c
> index 7d8ee85..e3b3dd9 100644
> --- a/src/xeniface/fdo.c
> +++ b/src/xeniface/fdo.c
> @@ -101,14 +101,14 @@ FdoInitialiseXSRegistryEntries(
>      RtlInitUnicodeString(&UnicodeValue, NULL);
>      RtlInitAnsiString(&AnsiValue, value);
> 
> -    Error("About to convert unicode string\n");
> +    Info("About to convert unicode string\n");
>      status = RtlAnsiStringToUnicodeString(&UnicodeValue, &AnsiValue,
> TRUE);
>      if (!NT_SUCCESS(status)) {
>          Error("Can't convert string\n");
>          goto failReg;
>      }
> 
> -    Error("About to write unicode string\n");
> +    Info("About to write unicode string\n");
>      status = ZwSetValueKey(RegHandle, &UnicodeValueName, 0, REG_SZ,
> UnicodeValue.Buffer, UnicodeValue.Length+sizeof(WCHAR));
>      if (!NT_SUCCESS(status)) {
>          Error("Can't write key\n");
> @@ -161,7 +161,7 @@ static NTSTATUS FdoRegistryThreadHandler(IN
> PXENIFACE_THREAD  Self,
>          status = KeWaitForMultipleObjects(REGISTRY_EVENTS, (PVOID
> *)threadevents, WaitAny, Executive, KernelMode, TRUE, NULL, NULL);
>          if ((status>=STATUS_WAIT_0) && (status <
> STATUS_WAIT_0+REGISTRY_EVENTS)) {
>              if (status == STATUS_WAIT_0+REGISTRY_WRITE_EVENT) {
> -                Error("WriteRegistry\n");
> +                Info("WriteRegistry\n");
>                  FdoInitialiseXSRegistryEntries(Fdo);
>                  KeClearEvent(threadevents[REGISTRY_WRITE_EVENT]);
>              }
> diff --git a/src/xeniface/wmi.c b/src/xeniface/wmi.c
> index 0f8ab8a..7059cb2 100644
> --- a/src/xeniface/wmi.c
> +++ b/src/xeniface/wmi.c
> @@ -750,7 +750,7 @@ WmiFireSuspendEvent(
>      IN  PXENIFACE_FDO   Fdo
>      )
>  {
> -    Error("Ready to unsuspend Event\n");
> +    Info("Ready to unsuspend Event\n");
>      KeSetEvent(&Fdo->registryWriteEvent, IO_NO_INCREMENT, FALSE);
> 
>      if (!Fdo->WmiReady)
> @@ -821,7 +821,7 @@ StartWatch(XENIFACE_FDO *fdoData,
> XenStoreWatch *watch)
>          return status;
>      }
> 
> -    Warning("Start Watch %p\n", watch->watchhandle);
> +    Info("Start Watch %p\n", watch->watchhandle);
> 
>      ExFreePool(tmppath);
>      RtlFreeAnsiString(&ansipath);
> @@ -870,7 +870,7 @@ VOID WatchCallbackThread(__in PVOID StartContext)
> {
>              } else if (!session->suspended &&
>                         watch->suspendcount != XENBUS_SUSPEND(GetCount, 
> &watch-
> >fdoData->SuspendInterface)) {
>                  watch->suspendcount = XENBUS_SUSPEND(GetCount, &watch-
> >fdoData->SuspendInterface);
> -                Warning("SessionSuspendResumeUnwatch %p\n", watch-
> >watchhandle);
> +                Info("SessionSuspendResumeUnwatch %p\n", watch-
> >watchhandle);
> 
>                  XENBUS_STORE(WatchRemove, &watch->fdoData->StoreInterface,
> watch->watchhandle);
>                  watch->watchhandle = NULL;
> --
> 2.8.3
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel