Re: [win-pv-devel] [PATCH] Succeed SRBs that the backend doesnt support

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel [mailto:win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx] On
> Behalf Of owen.smith@xxxxxxxxxx
> Sent: 05 December 2016 13:32
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> Subject: [win-pv-devel] [PATCH] Succeed SRBs that the backend doesnt
> support
> 
> From: Owen Smith <owen.smith@xxxxxxxxxx>
> 
> If the backend does not support BLKIF_OP_DISCARD,
> BLKIF_OP_WRITE_BARRIER,
> or BLKIF_OP_FLUSH_DISKCACHE, the first request will be failed and
> subsiquent requests will be succeeded instead of being passed to the
> backend. Bring the SRB status into line in both of these situations.
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

Acked-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

I'm also going to address that warning message.

> ---
>  src/xenvbd/pdo.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/xenvbd/pdo.c b/src/xenvbd/pdo.c
> index 3efe711..a3be031 100644
> --- a/src/xenvbd/pdo.c
> +++ b/src/xenvbd/pdo.c
> @@ -1539,7 +1539,8 @@ PdoCompleteResponse(
>      case BLKIF_RSP_EOPNOTSUPP:
>          // Remove appropriate feature support
>          FrontendRemoveFeature(Pdo->Frontend, Request->Operation);
> -        Srb->SrbStatus = SRB_STATUS_INVALID_REQUEST;
> +        // Succeed this SRB, subsiquent SRBs will be succeeded instead of 
> being
> passed to the backend.
> +        Srb->SrbStatus = SRB_STATUS_SUCCESS;
>          Warning("Target[%d] : %s BLKIF_RSP_EOPNOTSUPP (Tag %x)\n",
>                  PdoGetTargetId(Pdo), BlkifOperationName(Request->Operation),
> Tag);
>          break;
> --
> 2.8.3
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel