Re: [win-pv-devel] no-discard from xl not honored

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Andreas Kinzler [mailto:ml-ak@xxxxxxxxx]
> Sent: 16 February 2017 19:38
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>; win-pv-
> devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [win-pv-devel] no-discard from xl not honored
> 
> Here is my suggestion.
> 

That patch looks reasonable to me. Could you submit it properly to the list 
with your Signed-off-by? (See 
https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches for general 
guidance on patch submission... The PV drivers project uses the same process as 
the main hypervisor).

Thanks,

  Paul

> Regards Andreas
> 
> On 13.02.2017 10:00, Paul Durrant wrote:
> >> -----Original Message-----
> >> From: win-pv-devel [mailto:win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx]
> On
> >> Behalf Of Andreas Kinzler
> >> Sent: 10 February 2017 16:45
> >> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> >> Subject: [win-pv-devel] no-discard from xl not honored
> >>
> >> A disk spec like
> >>
> >> disk = [ '/dev/sda7,,hda,rw', '/dev/ram0,,hdb,rw,no-discard' ]
> >>
> >> leads to the following xenstore (at least with Xen 4.5.1)
> >>
> >>         discard-enable = "0"
> >>         feature-discard = "1"
> >>
> >> The driver only reads "feature-discard" but not "discard-enable" so
> >> discard is not disabled.
> >
> > Hmm. That's unfortunate, but fairly easily fixed. I'll see if I can come up 
> > with
> a patch later today.
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel