Re: [win-pv-devel] [PATCH 3/9] Remove RingTrigger

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel [mailto:win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx] On
> Behalf Of Owen Smith
> Sent: 29 May 2018 11:07
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> Subject: [win-pv-devel] [PATCH 3/9] Remove RingTrigger
> 
> RingTrigger calls XENBUS_EVTCHN(Trigger..) on during the suspend
> callback. Just before this, the ring is recreated and enabled, which
> also calls XENBUS_EVTCHN(Trigger..). The explicit call RingTrigger is
> unneccessary
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

Acked-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

> ---
>  src/xenvbd/frontend.c |  2 --
>  src/xenvbd/ring.c     | 13 -------------
>  src/xenvbd/ring.h     |  5 -----
>  3 files changed, 20 deletions(-)
> 
> diff --git a/src/xenvbd/frontend.c b/src/xenvbd/frontend.c
> index db96a36..47d744b 100644
> --- a/src/xenvbd/frontend.c
> +++ b/src/xenvbd/frontend.c
> @@ -1595,8 +1595,6 @@ FrontendSuspendCallback(
>          ASSERT(FALSE);
>      }
> 
> -    RingTrigger(Frontend->Ring);
> -
>      Verbose("Target[%d] : <=== restored %s\n", Frontend->TargetId,
> __XenvbdStateName(Frontend->State));
>  }
> 
> diff --git a/src/xenvbd/ring.c b/src/xenvbd/ring.c
> index 33b346d..e41c1b7 100644
> --- a/src/xenvbd/ring.c
> +++ b/src/xenvbd/ring.c
> @@ -2037,19 +2037,6 @@ RingDisconnect(
>      Ring->Received = 0;
>  }
> 
> -VOID
> -RingTrigger(
> -    IN  PXENVBD_RING    Ring
> -    )
> -{
> -    if (!Ring->Enabled)
> -        return;
> -
> -    XENBUS_EVTCHN(Trigger,
> -                  &Ring->EvtchnInterface,
> -                  Ring->Channel);
> -}
> -
>  BOOLEAN
>  RingQueueRequest(
>      IN  PXENVBD_RING    Ring,
> diff --git a/src/xenvbd/ring.h b/src/xenvbd/ring.h
> index 9b8a587..e3309e2 100644
> --- a/src/xenvbd/ring.h
> +++ b/src/xenvbd/ring.h
> @@ -74,11 +74,6 @@ RingDisconnect(
>      IN  PXENVBD_RING    Ring
>      );
> 
> -extern VOID
> -RingTrigger(
> -    IN  PXENVBD_RING    Ring
> -    );
> -
>  extern BOOLEAN
>  RingQueueRequest(
>      IN  PXENVBD_RING    Ring,
> --
> 2.16.2.windows.1
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/win-pv-devel
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel