Re: [win-pv-devel] [PATCH 4/9] Dont close ring during FrontendReset

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel [mailto:win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx] On
> Behalf Of Owen Smith
> Sent: 29 May 2018 11:07
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> Subject: [win-pv-devel] [PATCH 4/9] Dont close ring during FrontendReset
> 
> Closing the ring (and destroying the shared pages, etc) is not required
> when a HwStorResetBus or SRB_FUNCTION_RESET_DEVICE is triggered.
> Disabling the ring will cause any outstanding blkif_requests and SRBs to
> be failed.
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

Acked-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

> ---
>  src/xenvbd/frontend.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/src/xenvbd/frontend.c b/src/xenvbd/frontend.c
> index 47d744b..900ad2b 100644
> --- a/src/xenvbd/frontend.c
> +++ b/src/xenvbd/frontend.c
> @@ -1846,17 +1846,16 @@ FrontendReset(
>      IN  PXENVBD_FRONTEND    Frontend
>      )
>  {
> -    XENVBD_STATE            PreviousState = Frontend->State;
>      NTSTATUS                status;
> 
> -    if (PreviousState != XENVBD_ENABLED)
> +    if (Frontend->State != XENVBD_ENABLED)
>          goto done;
> 
> -    status = FrontendSetState(Frontend, XENVBD_CLOSED);
> +    status = FrontendSetState(Frontend, XENVBD_CONNECTED);
>      if (!NT_SUCCESS(status))
>          goto fail1;
> 
> -    status = FrontendSetState(Frontend, PreviousState);
> +    status = FrontendSetState(Frontend, XENVBD_ENABLED);
>      if (!NT_SUCCESS(status))
>          goto fail2;
> 
> --
> 2.16.2.windows.1
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/win-pv-devel
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel