Re: [win-pv-devel] SDV problem - spaces not quoted properly?

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel [mailto:win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx] On
> Behalf Of Marek Marczykowski-Górecki
> Sent: 09 July 2018 16:07
> To: win-pv-devel <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
> Subject: [win-pv-devel] SDV problem - spaces not quoted properly?
> 
> Hi,
> 
> I've run into weird SDV call problem. It fails with not so helpful
> message:
>   staticdv /check:default.sdv
>   SDV: C:\Program Files (x86)\Windows Kits\10\TOOLS\SDV
>   SMV: C:\Program Files (x86)\Windows Kits\10\TOOLS\SDV\smv
>   SDVAP: C:\Program Files (x86)\Windows
> Kits\10\TOOLS\SDV\smv\analysisplugins\sdv
>   Build environment: msbuild
> 
> (...)
> 
>   Building ...Done
>   [INFO] Using plugin SdvPlugin.SmvSdv for analysis.
>   [INFO] Running analysis on 26 precondition(s) & 158 rule(s) ...
>   [INFO] Checking preconditions...
>   [FATAL ERROR] Action: FinalCompile - startioroutine, failed.
> C:\Program Files (x86)\Windows
> Kits\10\build\windowsdriver.Sdv.targets(136,9): error MSB3073: The
> command "staticdv /check:default.sdv" exited with code -1.
> [E:\xeniface\vs2017\xeniface\xeniface.vcxproj]
> Done Building Project "E:\xeniface\vs2017\xeniface\xeniface.vcxproj" (sdv
> target(s)) -- FAILED.
> 
> After adding /debug to staticdv call, I've got something interesting -
> in vs2017/xeniface/sdv/check/startioroutine/smvexecute-FinalCompile.log
> it looks like spaces not quoted correctly in paths:
> 
>     cl : Command line warning D9027 : source file 'Files' ignored
>     cl : Command line warning D9024 : unrecognized source file type
> '(x86)\Windows', object file assumed
>     cl : Command line warning D9027 : source file '(x86)\Windows' ignored
>     cl : Command line warning D9024 : unrecognized source file type
> 'Kits\10\Include\10.0.17134.0\shared\warning.h /analyze /analyze:quiet
> /analyze:stacksize1024 /analyze:pluginC:\Program', object file assumed
>     cl : Command line warning D9027 : source file
> 'Kits\10\Include\10.0.17134.0\shared\warning.h /analyze /analyze:quiet
> /analyze:stacksize1024 /analyze:pluginC:\Program' ignored
>     cl : Command line warning D9024 : unrecognized source file type 'Files',
> object file assumed
> 
> Full file in [1].
> 
> As you can see there, some paths are correctly handled but not the
> others. I've found that those broken are all in
> vs2017/xeniface/sdv/sdv_cl.rsp[2] file, but I have no idea what it its
> relation for others.
> 
> For now I gave up and disabled SDV...
> 
> [1] https://gist.github.com/d2c8e2d6882bce6ac0528a40cd66e2d7
> [2] https://gist.github.com/4bef16dace8bea640c9e4cf4b57a55bf
>

Looking at these I reckon it is the setting of the __MODULE__ definition that 
is the problem. At 
https://gist.github.com/marmarek/d2c8e2d6882bce6ac0528a40cd66e2d7#file-startioroutine-smvexecute-finalcompile-log-L18
 you can see that the first thing in the error message is the half-quoted 
XENVIF" so it looks like the backslash quoting is not working correctly. If I 
can repro I'll see if I can find a decent workaround.

  Paul
 
> --
> Best Regards,
> Marek Marczykowski-Górecki
> Invisible Things Lab
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel