Re: [win-pv-devel] [PATCH xenvif 1/2] disable warning about spectre mitigation

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel [mailto:win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx] On
> Behalf Of Marek Marczykowski-Górecki
> Sent: 08 July 2018 01:39
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> Subject: [win-pv-devel] [PATCH xenvif 1/2] disable warning about spectre
> mitigation
> 
> CL emits a warning about every place that will get spectre mitigation
> when compiled with /Qspectre. Even if this option is already used. This
> breaks the build if warnings are treated as errors.
> 
> Signed-off-by: Marek Marczykowski-Górecki
> <marmarek@xxxxxxxxxxxxxxxxxxxxxx>

Acked-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

...but I also found that I need the same warning disabled for the coinstaller 
build too, so I'll add that.

  Paul

> ---
>  vs2017/xenvif/xenvif.vcxproj | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/vs2017/xenvif/xenvif.vcxproj b/vs2017/xenvif/xenvif.vcxproj
> index 1ce7438..fbbcce7 100644
> --- a/vs2017/xenvif/xenvif.vcxproj
> +++ b/vs2017/xenvif/xenvif.vcxproj
> @@ -24,7 +24,7 @@
> 
> <PreprocessorDefinitions>__MODULE__="XENVIF";POOL_NX_OPTIN=1;NT_
> PROCESSOR_GROUPS;%(PreprocessorDefinitions)</PreprocessorDefinitions
> >
>        <IntrinsicFunctions>true</IntrinsicFunctions>
>        <WarningLevel>EnableAllWarnings</WarningLevel>
> -
> <DisableSpecificWarnings>4464;4711;4770;4548;4820;4668;4255;6001;6054;28
> 196;30030;30029;%(DisableSpecificWarnings)</DisableSpecificWarnings>
> +
> <DisableSpecificWarnings>4464;4711;4770;4548;4820;4668;4255;5045;6001;60
> 54;28196;30030;30029;%(DisableSpecificWarnings)</DisableSpecificWarnings
> >
>        <MultiProcessorCompilation>true</MultiProcessorCompilation>
>        <EnablePREfast>true</EnablePREfast>
>      </ClCompile>
> --
> 2.13.6
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/win-pv-devel
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel