Re: [win-pv-devel] [PATCH xennet 1/2] xennet: disable warning about spectre mitigation

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel [mailto:win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx] On
> Behalf Of Marek Marczykowski-Górecki
> Sent: 08 July 2018 01:36
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> Subject: [win-pv-devel] [PATCH xennet 1/2] xennet: disable warning about
> spectre mitigation
> 
> CL emits a warning about every place that will get spectre mitigation
> when compiled with /Qspectre. Even if this option is already used. This
> breaks the build, as warnings are treated as errors in xeniface.
> 
> Signed-off-by: Marek Marczykowski-Górecki
> <marmarek@xxxxxxxxxxxxxxxxxxxxxx>

Acked-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

...also with it disabled in the coinstaller build (which is not actually 
necessary as yet but better to put it in now).

  Paul

> ---
>  vs2017/xennet/xennet.vcxproj | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/vs2017/xennet/xennet.vcxproj b/vs2017/xennet/xennet.vcxproj
> index 387cdf5..a64d0cb 100644
> --- a/vs2017/xennet/xennet.vcxproj
> +++ b/vs2017/xennet/xennet.vcxproj
> @@ -26,7 +26,7 @@
>        <IntrinsicFunctions>true</IntrinsicFunctions>
> 
> <AdditionalIncludeDirectories>$(WindowsSdkDir)\include\km;..\..\include;..
> \..\include\xen;</AdditionalIncludeDirectories>
>        <WarningLevel>EnableAllWarnings</WarningLevel>
> -
> <DisableSpecificWarnings>4464;4711;4770;4548;4820;4668;4255;6001;6054;28
> 160;28196;30030;30029;%(DisableSpecificWarnings)</DisableSpecificWarning
> s>
> +
> <DisableSpecificWarnings>4464;4711;4770;4548;4820;4668;4255;5045;6001;60
> 54;28160;28196;30030;30029;%(DisableSpecificWarnings)</DisableSpecificWa
> rnings>
>        <MultiProcessorCompilation>true</MultiProcessorCompilation>
>        <EnablePREfast>true</EnablePREfast>
>      </ClCompile>
> --
> 2.13.6
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/win-pv-devel
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel