Re: [win-pv-devel] [PATCH xeniface 3/4] xeniface: fix warning about xeniface.inf

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel [mailto:win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx] On
> Behalf Of Marek Marczykowski-Górecki
> Sent: 08 July 2018 01:31
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> Subject: [win-pv-devel] [PATCH xeniface 3/4] xeniface: fix warning about
> xeniface.inf
> 
> stampinf(?) complains about explicit CoInstallers32:
> 
> E:\xeniface\vs2017\xeniface.inf(89-89): warning 1303: Found legacy AddReg
> operation defining co-installers (CoInstallers32).
> [E:\xeniface\vs2017\xeniface\xeniface.vcxproj]
> Signed-off-by: Marek Marczykowski-Górecki
> <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> ---
>  src/xeniface.inf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/xeniface.inf b/src/xeniface.inf
> index 75d44eb..cdb7e3c 100644
> --- a/src/xeniface.inf
> +++ b/src/xeniface.inf
> @@ -88,7 +88,7 @@ CopyFiles=CoInst.NT.Copy
>  AddReg=CoInst_AddReg
> 
>  [CoInst_AddReg]
> -
> HKR,,CoInstallers32,0x00010000,"xeniface_coinst_@MAJOR_VERSION@_@
> MINOR_VERSION@_@MICRO_VERSION@_@BUILD_NUMBER@.dll,Entry"
> +HKR,,,0x00010000,"xeniface_coinst_@MAJOR_VERSION@_@MINOR_VERS
> ION@_@MICRO_VERSION@_@BUILD_NUMBER@.dll,Entry"
> 

AFAICT this is going to add an unnamed registry key instead of the well-known 
coinstaller key and hence stop the co-installer from working. Visual Studio may 
complain but until Microsoft tell me how to replace co-installer functionality, 
these keys need to stay.

  Paul

>  [xenagent_Service_Inst]
>  DisplayName    = %xenagent.SVCDESC%
> --
> 2.13.6
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/win-pv-devel
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel