Re: [win-pv-devel] [PATCH] Suppress warning 4715

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel [mailto:win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx] On 
> Behalf Of Owen Smith
> Sent: 07 June 2019 09:43
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> Subject: [win-pv-devel] [PATCH] Suppress warning 4715
> 
> __CacheMaskScan can trigger a compiler warning with some compilers due
> to not all return paths returning a value. The path that does not return
> a value calls KeBugCheckEx, which would leave unreachable code. Disable
> the specific warning for this function.
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

Acked-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

> ---
>  src/xenbus/cache.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/xenbus/cache.c b/src/xenbus/cache.c
> index 7daf8da..9713df3 100644
> --- a/src/xenbus/cache.c
> +++ b/src/xenbus/cache.c
> @@ -348,6 +348,7 @@ CacheDestroySlab(
>      MmFreeContiguousMemory(Slab);
>  }
> 
> +#pragma warning(disable: 4715)
>  static FORCEINLINE ULONG
>  __CacheMaskScan(
>      IN  ULONG   *Mask,
> @@ -374,6 +375,7 @@ __CacheMaskScan(
> 
>      BUG("CACHE SCAN FAILED");
>  }
> +#pragma warning(default: 4715)
> 
>  static FORCEINLINE VOID
>  __CacheMaskSet(
> --
> 2.16.2.windows.1
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/win-pv-devel
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel