[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [win-pv-devel] Two patches to ease upgrade from older drivers.


  • To: Martin Harvey <martin.harvey@xxxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: "Durrant, Paul" <pdurrant@xxxxxxxxxxxx>
  • Date: Tue, 3 Mar 2020 12:40:04 +0000
  • Accept-language: en-GB, en-US
  • Delivery-date: Tue, 03 Mar 2020 12:40:12 +0000
  • Ironport-sdr: buqyALQ00eeGBe6szedqIJaAErWx323f7wBdzrqmlDevZk+wByT9GrW30aIqKQzCn4Ljb1BPZ9 AvkVKzdpUrEA==
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
  • Thread-index: AdXwtIYr0neRyqE9QY2L/LWg8Ka1gAAojj7g
  • Thread-topic: [win-pv-devel] Two patches to ease upgrade from older drivers.

De-htmling...

Responses below:

-----
From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of 
Martin Harvey
Sent: 02 March 2020 17:09
To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Subject: [EXTERNAL][win-pv-devel] Two patches to ease upgrade from older 
drivers.

CAUTION: This email originated from outside of the organization. Do not click 
links or open attachments unless you can confirm the sender and know the 
content is safe.


Submitted for consideration:

When upgrading from older drivers, installer upgrades can fail, when new NET 
co-installer refuses to recognise older VIF enumerated devices. The subsequent 
requested reboot leaves the device tree with hidden devices with entries still 
in the MIB table. If these devices are not properly recognised as being 
dormant, they will prevent startup of the new-version NET devices.


For machines already in this broken state, a suitable workaround is:

1. Tried to do the MSI install. Got the failure case, greyed out disabled dev 
nodes.
2.  Remove greyed out devnodes with "uninstall device" (don't delete any 
drivers).
3. On reboot, Xenserver PV Network devices not present: because Xenbus DEV_VIF 
(one up the device tree) is not starting properly.
4. Select  "Upgrade Drivers" for DEV_VIF manually, and reboot the machine.
5. Upon reboot, machine in working state.

MH.
-----

Please send patches to this list using the same procedures as sending to 
xen-devel. See https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches 
for help with that. (Personally I find get send-email the best way). 
Particularly each patch needs a commit message that adequately justifies its 
existence, so that in many years' time mining the repo will give a clue as to 
why each change is there. (Remember cover letters don't get committed :-))

The older revisions patch cannot work because VIF interface versions older than 
6 are no longer implemented, thus it would be unsafe to use it in the presence 
of an older XENNET (because interface acquire would fail) and leave it 
non-functional, whereas it should be left non-binding thus allowing emulated 
devices to be re-instated. If that is not happening then that's a bug that 
needs fixing... but maybe that's what the other patch does?
The other patch does not have an adequate commit comment... I guess some of the 
text here could be added to justify it.

  Cheers,

    Paul

_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.