[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[win-pv-devel] [PATCH] Reorder StorePollLocked and StoreDisable


  • To: <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Owen Smith <owen.smith@xxxxxxxxxx>
  • Date: Wed, 4 Mar 2020 13:27:23 +0000
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=owen.smith@xxxxxxxxxx; spf=Pass smtp.mailfrom=owen.smith@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Cc: Owen Smith <owen.smith@xxxxxxxxxx>
  • Delivery-date: Wed, 04 Mar 2020 13:27:55 +0000
  • Ironport-sdr: CKqsJ8ntIzkxtEdj3xZRf3m5fDlA2b78XZlw2lpC9sw4behm+h1vQnUXs/GZoi3jjgrC5NJ5r5 6SIha5qq536/BtfZLpF1qzX40DbcWxbJ8RhtZTyy67z3MgC62bzt49eXV9YxP4L88NuG0nwdtM htoYstKuTNRR6qV4rFG9+YX+s3FT1PZaMQS1ECI7AxvbuNzCUaZ1oqx96tn5NGXShPOU6rMZnV TXYMJN2Hn+bnmHsTfHB2/ElOvr8VPz7/fgLfFviUqX06ZYVTnatsE/DFbp2Z3D6whVfnZP4bqW 1Ig=
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

StoreDisable will close and NULL the event channel, then StorePollLocked
will attempt to call EVTCHN(GetCount...) with the NULLed pointer. This
will lead to a D1 BSOD.

Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>
---
 src/xenbus/store.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/xenbus/store.c b/src/xenbus/store.c
index f07e469..cbc442e 100644
--- a/src/xenbus/store.c
+++ b/src/xenbus/store.c
@@ -2611,8 +2611,8 @@ StoreRelease(
 
     XENBUS_SUSPEND(Release, &Context->SuspendInterface);
 
-    StoreDisable(Context);
     (VOID) StorePollLocked(Context);
+    StoreDisable(Context);
     RtlZeroMemory(&Context->Response, sizeof (XENBUS_STORE_RESPONSE));
 
     XENBUS_EVTCHN(Release, &Context->EvtchnInterface);
-- 
2.16.2.windows.1


_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.