Re: [win-pv-devel] [PATCH] Reorder StorePollLocked and StoreDisable

["Durrant, Paul" <pdurrant@xxxxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of 
> Owen Smith
> Sent: 04 March 2020 13:27
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> Subject: [EXTERNAL][win-pv-devel] [PATCH] Reorder StorePollLocked and 
> StoreDisable
> 
> CAUTION: This email originated from outside of the organization. Do not click 
> links or open
> attachments unless you can confirm the sender and know the content is safe.
> 
> 
> 
> StoreDisable will close and NULL the event channel, then StorePollLocked
> will attempt to call EVTCHN(GetCount...) with the NULLed pointer. This
> will lead to a D1 BSOD.
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

Reviewed-by: Paul Durrant <pdurrant@xxxxxxxxxx>

Ouch! I wonder why I've never spotted this in testing. This is going to need 
back-porting too.

  Paul

> ---
>  src/xenbus/store.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/xenbus/store.c b/src/xenbus/store.c
> index f07e469..cbc442e 100644
> --- a/src/xenbus/store.c
> +++ b/src/xenbus/store.c
> @@ -2611,8 +2611,8 @@ StoreRelease(
> 
>      XENBUS_SUSPEND(Release, &Context->SuspendInterface);
> 
> -    StoreDisable(Context);
>      (VOID) StorePollLocked(Context);
> +    StoreDisable(Context);
>      RtlZeroMemory(&Context->Response, sizeof (XENBUS_STORE_RESPONSE));
> 
>      XENBUS_EVTCHN(Release, &Context->EvtchnInterface);
> --
> 2.16.2.windows.1
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/win-pv-devel
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel