[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 2/3] No longer terminate xenagent for S3/S4 transition.
- To: Troy Crosley <troycrosley@xxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Owen Smith <owen.smith@xxxxxxxxxx>
- Date: Thu, 3 Sep 2020 15:08:49 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hPMBBl8W9QJ66AojJsbo7vc6hAqFUh+C2Em4eiGjWIE=; b=WIaHC1+DoxKOd7SnxmCRbqnMaeqRyEyfmahT7QqKZSpRXBCPH/JhSM68ja+FF5yologa4yoc9RDyM0bmRg5cDztfh3h3LGePdQ3V1kn9KgbfBqgpfTc5flm3whKQcS3CQkCl7Fjadvm+47zTGhpdLwylyz2XGng8VkRsETEXHm/AcDZaKdEOUxOkkqZ9M5H7Ss1T66tqz+k5dkWFL2BX2GZt0pxQwZprkOTl6+Jac/+3bl9Tq9YwVB3c0RmjSZhTQbx49ZPM1i328OstkkXlDRsvMvo4eCwLNgunN+Okqkx5sZHmd8oU2/0JW69PPfGpDgModVoBNYAyYw6KRbMNdw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UEyx406ktnNn3iTAv9GCh1hLGJIzMocV7lgMUmVG795/uyaL6dhvxHvreWUo/eMnD1Q45G4j0cNa2c10V2IAyVUUt+TE4k//i0Q+e0F+WHv81w3sAFiZDYjLYw2E68j2Eujnce/6JIbhwV5WNZMURu3Zx/bQQDwQOhB+/lDC7lRharHfeENzL71GThHcQETO6kUnwB+nYMFF7stT/riG/J8wtx203lPrSDaiCxvl7iKe+hsY9pQ3tX/hP1q9R/a/NUL75JrC5x5mmOODFZkBTnHeVHxzjQeipvegHFjnetcryVF1gn6Jd1VoX8Y8iym5RtBeX4YMEHwijB3r6vz58Q==
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "paul@xxxxxxx" <paul@xxxxxxx>, Ben Chalmers <ben.chalmers@xxxxxxxxxx>
- Delivery-date: Thu, 03 Sep 2020 15:08:59 +0000
- Ironport-sdr: sR2nnSOBp9muM+c2Fc0DNJMH/Vhe6R7yEm62i32U6mKRMK4+yQrdkGbiA5v7CjuXUo5g6wxDeB G1p+UgSIJdFWmEQjutVFjgPxHTPIZSEK2UloYKylQYdTJu+WHQxwZsJw0aqGzmdghhs3al4kL9 1vQtbZQMF86C4WE+L3BWVJvpt5NvLtO+DMTCx8jP+i4Kk6Ft/Es7rxk3Ta3VYBLWTKCLsVm6my KY6VfYk2y6ZDsBfA6LgJnf2TuD88lRvzU/oqUzdWzXPLCr4ChKmfizBGXh/hJlpBLglcvDBDut m1Q=
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Thread-index: AQHWgIVEzeww9dQ4bEy4K/T1q20Yz6lXBwOg
- Thread-topic: [PATCH 2/3] No longer terminate xenagent for S3/S4 transition.
Looks good,
Reviewed-by: Owen Smith <owen.smith@xxxxxxxxxx>
> -----Original Message-----
> From: Troy Crosley <troycrosley@xxxxxxxxx>
> Sent: 01 September 2020 18:28
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: paul@xxxxxxx; Ben Chalmers <ben.chalmers@xxxxxxxxxx>; Owen Smith
> <owen.smith@xxxxxxxxxx>; Troy Crosley <troycrosley@xxxxxxxxx>
> Subject: [PATCH 2/3] No longer terminate xenagent for S3/S4 transition.
>
> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments
> unless you have verified the sender and know the content is safe.
>
> Signed-off-by: Troy Crosley <troycrosley@xxxxxxxxx>
> ---
> src/xenagent/service.cpp | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/xenagent/service.cpp b/src/xenagent/service.cpp index
> e595093..3630240 100644
> --- a/src/xenagent/service.cpp
> +++ b/src/xenagent/service.cpp
> @@ -224,7 +224,7 @@ bool CXenIfaceCreator::CheckShutdown()
> if (!SetSystemPowerState(FALSE, FALSE)) {
> CXenAgent::Log("SetSystemPowerState failed %08x\n",
> GetLastError());
> }
> - return true;
> + return false;
> } else if (type == "s3") {
> m_device->StoreWrite("control/shutdown", "");
> m_agent.EventLog(EVENT_XENUSER_S3);
> @@ -233,7 +233,7 @@ bool CXenIfaceCreator::CheckShutdown()
> if (!SetSuspendState(FALSE, TRUE, FALSE)) {
> CXenAgent::Log("SetSuspendState failed %08x\n", GetLastError());
> }
> - return true;
> + return false;
> }
>
> return false;
> --
> 2.20.1
>
|
