[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 3/3] Avoid unnecessary assertion.
- To: Troy Crosley <troycrosley@xxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Owen Smith <owen.smith@xxxxxxxxxx>
- Date: Thu, 3 Sep 2020 15:15:04 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Up0wSDAHkhRmqFcGyDSp+qhX280uJumqrBc3TotBXR4=; b=RJex+B3obYX8oP5FPtYaxD5uMya2iDjZe0tsk7jLDF5x1qq52JkxSNG4RxhpeCy4KQV64AtpCL55dbEWDsFi8p8h2ZUVuA+dv8bEg9Yj1ohJ6oJvbvzXlFNaaXSHLmycAmbHQci4ePa2+Db+4RO2qyPoqbpLBd8HXyYEJsWkvq0YriGYk0qXb0iV45FPu4p1yzWezy9dRxmbK0B9+EZppqoTDTjQiMC8bXRMgE7s6oY6ir3osmqAgex7Ju4WqyQdOyG8FgvyJgjnCSYEuK/V4TyfRA0Ia0nxhv2tJ08kmR3rqFfIo7auawAnR/9NHLmKPSnuBKPxGH6FppOmddzdgw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lvkxfD/Hd+FcZ+y2lthBMByGt8JEigA2lKXoqZ9cAW1xlShOzbqOo8SHzTLo/r8Qn5hUL5rM7VP/xTRh6aR5t+/2cynvOh/AfxCUylJ9E342JEwrGjTN5HGp7oVO7lxgx5LlGRgTznrqvSfYFFCyhBsEKiKmgB9Unxf2RefvVJjAC0wfJ1bNLeNEo0jEfDEG/93ZTm5GySqP4yjIR5zg2u5c9RhxZRXjK0XdTrivWElePJ+3FUTb2gWvybPb7zJr8rW/N9sPPBdZQAbrR3spnxX8BrxuG2MVpgz7SHsp/qZLWHlmJEjxUL+MyHuJvnyyDnNpiKVBDHhwg+fRnayXpg==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "paul@xxxxxxx" <paul@xxxxxxx>, Ben Chalmers <ben.chalmers@xxxxxxxxxx>
- Delivery-date: Thu, 03 Sep 2020 15:15:10 +0000
- Ironport-sdr: F+RIbNIMll3d++cns4E8GJmmz97z378++daiDHPzmpZZw5ic0eavMw1KvAuyuZdBdxKX35iCCu GZms6yOR2F9lvpyqn6XdOYYly04L4OvJhH/HuiQG5EefEI2LN1gV+a8O+pQfngracE3wAbWLzr T9r/CIfvabeZqoHDDxb8AIX09WAI3QdzwiirAFewhI1v2h/W45M/dRf/32ocQJ8hpyeryTHjby 7tbDKU4rKAWLuo0SYPApnCpddK8JZnwXwaz22pTL2zSPHxvDyk2tFoRv9Mjylk8Ewx0aq0QfSK 858=
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Thread-index: AQHWgIVFKID2vfzs2kKMiYayk5TdLqlXCC5A
- Thread-topic: [PATCH 3/3] Avoid unnecessary assertion.
Looks good,
Reviewed-by: Owen Smith <owen.smith@xxxxxxxxxx>
> -----Original Message-----
> From: Troy Crosley <troycrosley@xxxxxxxxx>
> Sent: 01 September 2020 18:28
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: paul@xxxxxxx; Ben Chalmers <ben.chalmers@xxxxxxxxxx>; Owen Smith
> <owen.smith@xxxxxxxxxx>; Troy Crosley <troycrosley@xxxxxxxxx>
> Subject: [PATCH 3/3] Avoid unnecessary assertion.
>
> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments
> unless you have verified the sender and know the content is safe.
>
> Add the missing brackets to an if statement so that FdoS4ToS3() is not always
> called in __FdoSetSystemPowerUp().
>
> Signed-off-by: Troy Crosley <troycrosley@xxxxxxxxx>
> ---
> src/xeniface/fdo.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/xeniface/fdo.c b/src/xeniface/fdo.c index 1f859cd..6aabf96
> 100644
> --- a/src/xeniface/fdo.c
> +++ b/src/xeniface/fdo.c
> @@ -1740,9 +1740,10 @@ __FdoSetSystemPowerUp(
> goto done;
>
> if (SystemState < PowerSystemHibernate &&
> - __FdoGetSystemPowerState(Fdo) >= PowerSystemHibernate)
> + __FdoGetSystemPowerState(Fdo) >= PowerSystemHibernate) {
> __FdoSetSystemPowerState(Fdo, PowerSystemHibernate);
> FdoS4ToS3(Fdo);
> + }
>
> Info("%s -> %s\n",
> PowerSystemStateName(__FdoGetSystemPowerState(Fdo)),
> --
> 2.20.1
>
|
