RE: [PATCH] Clear rather than remove control/feature-XXX keys.

[Paul Durrant <xadimgnik@xxxxxxxxx>]

> -----Original Message-----
> From: Troy Crosley <troycrosley@xxxxxxxxx>
> Sent: 03 September 2020 15:54
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: paul@xxxxxxx; ben.chalmers@xxxxxxxxxx; owen.smith@xxxxxxxxxx; Troy 
> Crosley <troycrosley@xxxxxxxxx>
> Subject: [PATCH] Clear rather than remove control/feature-XXX keys.
> 
> These keys should stick around when disabled since they're present at
> boot. This also fixes an issue where the keys are unable to be written
> on wake from S3 or S4.

Good catch... the remove is a XenServer-ism that should indeed go away.

Reviewed-by: Paul Durrant <paul@xxxxxxx>

> 
> Signed-off-by: Troy Crosley <troycrosley@xxxxxxxxx>
> ---
>  src/xenagent/service.cpp | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/xenagent/service.cpp b/src/xenagent/service.cpp
> index 3630240..e71059c 100644
> --- a/src/xenagent/service.cpp
> +++ b/src/xenagent/service.cpp
> @@ -331,10 +331,10 @@ void CXenIfaceCreator::StopShutdownWatch()
>      if (!m_ctxt_shutdown)
>          return;
> 
> -    m_device->StoreRemove("control/feature-poweroff");
> -    m_device->StoreRemove("control/feature-reboot");
> -    m_device->StoreRemove("control/feature-s3");
> -    m_device->StoreRemove("control/feature-s4");
> +    m_device->StoreWrite("control/feature-poweroff", "");
> +    m_device->StoreWrite("control/feature-reboot", "");
> +    m_device->StoreWrite("control/feature-s3", "");
> +    m_device->StoreWrite("control/feature-s4", "");
> 
>      m_device->StoreRemoveWatch(m_ctxt_shutdown);
>      m_ctxt_shutdown = NULL;
> --
> 2.20.1