RE: [PATCH 1/2] Allow user to specify desired build architecture

[Paul Durrant <xadimgnik@xxxxxxxxx>]

> -----Original Message-----
> From: Paul Durrant <xadimgnik@xxxxxxxxx>
> Sent: 09 November 2020 09:06
> To: 'Owen Smith' <owen.smith@xxxxxxxxxx>; 'Nicholas Tsirakis' 
> <niko.tsirakis@xxxxxxxxx>; win-pv-
> devel@xxxxxxxxxxxxxxxxxxxx
> Cc: 'Ben Chalmers' <ben.chalmers@xxxxxxxxxx>; 'Nicholas Tsirakis' 
> <tsirakisn@xxxxxxxxxxxx>
> Subject: RE: [PATCH 1/2] Allow user to specify desired build architecture
> 
> > -----Original Message-----
> > From: Owen Smith <owen.smith@xxxxxxxxxx>
> > Sent: 09 November 2020 08:08
> > To: Nicholas Tsirakis <niko.tsirakis@xxxxxxxxx>; 
> > win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> > Cc: paul@xxxxxxx; Ben Chalmers <ben.chalmers@xxxxxxxxxx>; Nicholas Tsirakis 
> > <tsirakisn@xxxxxxxxxxxx>
> > Subject: RE: [PATCH 1/2] Allow user to specify desired build architecture
> >
> 
> Let's try to avoid top-posting :-)
> 
> > I would suggest using
> > [string]::IsNullOrEmpty($Arch)
> > Instead of
> > $Arch -eq ""
> >
> 
> Agreed. I can make the change while committing so no need for a v2.
> 
> Acked-by: Paul Durrant <paul@xxxxxxx>

Actually, I jumped the gun here. Having started to apply this I realize it's 
not going to work because of the optional '$Sdv'
parameter after it. IOW how do we do a default (IOW both x86 and x64) build 
with the sdv option?

  Paul

> 
> > Owen
> >
> > > -----Original Message-----
> > > From: Nicholas Tsirakis <niko.tsirakis@xxxxxxxxx>
> > > Sent: 06 November 2020 20:49
> > > To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> > > Cc: paul@xxxxxxx; Ben Chalmers <ben.chalmers@xxxxxxxxxx>; Owen Smith
> > > <owen.smith@xxxxxxxxxx>; Nicholas Tsirakis <tsirakisn@xxxxxxxxxxxx>
> > > Subject: [PATCH 1/2] Allow user to specify desired build architecture
> > >
> > > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments
> > > unless you have verified the sender and know the content is safe.
> > >
> > > Often times we only need to build a driver for a single targeted 
> > > architecture.
> > > Continue to build both by default, but allow the user to specify one if 
> > > desired.
> > >
> > > Signed-off-by: Nicholas Tsirakis <tsirakisn@xxxxxxxxxxxx>
> > > ---
> > >  build.ps1 | 10 ++++++++--
> > >  1 file changed, 8 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/build.ps1 b/build.ps1
> > > index c66ac05..06626fd 100644
> > > --- a/build.ps1
> > > +++ b/build.ps1
> > > @@ -5,6 +5,7 @@
> > >  param(
> > >   [Parameter(Mandatory = $true)]
> > >   [string]$Type,
> > > + [string]$Arch,
> > >   [switch]$Sdv
> > >  )
> > >
> > > @@ -82,8 +83,13 @@ Set-Item -Path Env:MAJOR_VERSION -Value '9'
> > >  Set-Item -Path Env:MINOR_VERSION -Value '1'
> > >  Set-Item -Path Env:MICRO_VERSION -Value '0'
> > >
> > > -Build "x86" $Type
> > > -Build "x64" $Type
> > > +if ($Arch -eq "" -or $Arch -eq "x86" -or $Arch -eq "Win32") {
> > > + Build "x86" $Type
> > > +}
> > > +
> > > +if ($Arch -eq "" -or $Arch -eq "x64") {
> > > + Build "x64" $Type
> > > +}
> > >
> > >  if ($Sdv) {
> > >   SdvBuild
> > > --
> > > 2.25.4
> > >
>