[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Fix Activev Device Present logging


  • To: <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Owen Smith <owen.smith@xxxxxxxxxx>
  • Date: Mon, 15 Feb 2021 12:02:48 +0000
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Owen Smith <owen.smith@xxxxxxxxxx>
  • Delivery-date: Mon, 15 Feb 2021 12:03:18 +0000
  • Ironport-sdr: IxdKX48OzfeSGkeDuyD/fYRMSFX/OlmpgJ2Glx1rHhcW5eNmcjnSJvLMm/ANm1e52JMUHfflE2 gbPgkl/BEErlhfIS1N9TuiK5d/+6iDgDtCfTUzE9FLts8tgQzn7ClP82bvYHirwYw2TrQz2wCH 66j5C8NDuQzIf9IPpbBFrsNoXfLpg77UhH57ym4yLzeMduHxD25cv0lCK8Sl/iOoYWt2XFG5f9 h7CO1xmY8IP6MRUjWms9iGJF6Ql/3FkN8OWYxKICd7Aq2W+llSGtF5Q5hOcuuxCKVb8b/ZOtyo IgM=
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

Log active device presence from DriverIsActiveDevicePresent, rather than
the caller when DriverIsActiveDevicePresent reported its present. This
move fixes the non-functional conditional in the logging.

Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>
---
 src/xenfilt/driver.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/xenfilt/driver.c b/src/xenfilt/driver.c
index 5496a17..e9e6673 100644
--- a/src/xenfilt/driver.c
+++ b/src/xenfilt/driver.c
@@ -324,6 +324,8 @@ DriverIsActivePresent(
 done:
     XENFILT_EMULATED(Release, &Driver.EmulatedInterface);
 
+    Info("ACTIVE DEVICE %sPRESENT\n", (!Present) ? "NOT " : "");
+
     return Present;
 
 fail1:
@@ -362,8 +364,6 @@ DriverSetFilterState(
             break;
 
         if (DriverIsActivePresent()) {
-            Info("ACTIVE DEVICE %sPRESENT\n", (!Present) ? "NOT " : "");
-
             if (!__DriverSafeMode())
                 UnplugDevices();
         }
-- 
2.28.0.windows.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.