RE: [PATCH] Fix Activev Device Present logging

[Paul Durrant <xadimgnik@xxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of 
> Owen Smith
> Sent: 15 February 2021 12:03
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> Subject: [PATCH] Fix Activev Device Present logging
> 
> Log active device presence from DriverIsActiveDevicePresent, rather than
> the caller when DriverIsActiveDevicePresent reported its present. This
> move fixes the non-functional conditional in the logging.
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

Typo in the subject line, but I'll fix that on commit...

Acked-by: Paul Durrant <paul@xxxxxxx>

> ---
>  src/xenfilt/driver.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/xenfilt/driver.c b/src/xenfilt/driver.c
> index 5496a17..e9e6673 100644
> --- a/src/xenfilt/driver.c
> +++ b/src/xenfilt/driver.c
> @@ -324,6 +324,8 @@ DriverIsActivePresent(
>  done:
>      XENFILT_EMULATED(Release, &Driver.EmulatedInterface);
> 
> +    Info("ACTIVE DEVICE %sPRESENT\n", (!Present) ? "NOT " : "");
> +
>      return Present;
> 
>  fail1:
> @@ -362,8 +364,6 @@ DriverSetFilterState(
>              break;
> 
>          if (DriverIsActivePresent()) {
> -            Info("ACTIVE DEVICE %sPRESENT\n", (!Present) ? "NOT " : "");
> -
>              if (!__DriverSafeMode())
>                  UnplugDevices();
>          }
> --
> 2.28.0.windows.1
>