Re: [PATCH] Disable CONS debug logging

[Paul Durrant <xadimgnik@xxxxxxxxx>]

On 07/07/2021 09:54, Martin Harvey wrote:
> From: Owen Smith <owen.smith@xxxxxxxxxx>
a) Why?

> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>
> ---
>   src/xenbus/driver.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/xenbus/driver.c b/src/xenbus/driver.c
> index 1b621fa..f353a61 100644
> --- a/src/xenbus/driver.c
> +++ b/src/xenbus/driver.c
> @@ -58,10 +58,10 @@ typedef struct _XENBUS_DRIVER {
>   static XENBUS_DRIVER    Driver;
>   
>   #define XENBUS_DRIVER_TAG   'VIRD'
> -#define DEFAULT_CONSOLE_LOG_LEVEL   (LOG_LEVEL_INFO |       \
> -                                     LOG_LEVEL_WARNING |    \
> -                                     LOG_LEVEL_ERROR |      \
> -                                     LOG_LEVEL_CRITICAL)
> +#define DEFAULT_CONSOLE_LOG_LEVEL   0 // (LOG_LEVEL_INFO |       \
> +                                      //  LOG_LEVEL_WARNING |    \
> +                                      //  LOG_LEVEL_ERROR |      \
> +                                      //  LOG_LEVEL_CRITICAL)
b) Leaving code in comments like this is not something we want

If there is a reasonable justification for why we want no logging 
through the console then ditch the comments.
  Paul

>   
>   static FORCEINLINE PVOID
>   __DriverAllocate(