[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] Disable CONS debug logging
- To: "paul@xxxxxxx" <paul@xxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Owen Smith <owen.smith@xxxxxxxxxx>
- Date: Tue, 13 Jul 2021 08:10:54 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kLycbmEpnavQnyOHNCg7PtUGnwOl8JrUrr+DuJZLhnQ=; b=f99oCEl1eeh/YdLVK3TlCZ16pD/+WkicYb98In42ojpQ1bnkaUrxS2n5EYBHb0CQAyrxO5cJdZ+R3YYNOoCd6VVXa3f2TqjYsuFC2ZkU+q6RHcZP9nH87gVWFYe+q8ViK1mxnCmKrgEqhN1ru0YllkE9gm9CHxnLP24AzgUrG8GCtjPTnOUwTrA8Iwo12tsuhXXFqfYcI3GSRjibFAGOIWOOO1pgDc0elbsrlVVbGTkqrSr4j6OetkntH8bopTwBkDuWKVqfy93ys7NNPdB3/ewn9jxwXW033maYXqDmKST83UP1IHNL/Or6TbaE2VY35eM9dFmKzx0/4d0TuDYFVw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dcWFS/JMokOa1qODlpRA9Z5N0PpnAykZ9e3ThmqruZL2YeL1pBOygI3wITct91CH0yPd5YspZFI20yI/+Oow1w99SnHOiEJ2CkW358AW2uF13TfYf0/IvsEyFIlSXUjFao2JMsXbIRzUH82+AoL+YRYfYdnjmooZdfYq2JAutcxas6juhHBfJ+fbMUofmg64OQ3BWTP6MzeZygv8Hv/LAjy8bpf2zSeWQRFAB6yQUsq6446pm/HTFIp/qcBtVhotJu0IImndFZpywedknyef691GNY/lJCDTPjaY4736qBAxmWkjdE1vdnbr1Ef45HC4f4gEGcyDBnBi+olcnfJM5Q==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Martin Harvey <martin.harvey@xxxxxxxxxx>
- Delivery-date: Tue, 13 Jul 2021 08:11:06 +0000
- Ironport-hdrordr: A9a23:W7AwOK+vWI0T/xZlnSpuk+FUdb1zdoMgy1knxilNoENuHPBwxv rAoB1E73PJYW4qKQ0dcdDpAtjlfZquz+8L3WB3B8btYOCGghrmEGgG1+rfKlLbalXDH4JmpM Vdmu1FeaDN5DtB/IfHCWuDYq0dKbC8mcjC74q/vhRQpENRGttdBm9Ce12m+yZNNW577O8CZe OhD7181lydkBosH6GGL0hAe9KGi8zAlZrgbxJDLQUg8hOygTSh76O/OwSE3z8FOgk/gYsKwC zgqUjU96+ju/a0xlv3zGnI9albn9Pn159qGNGMsM4IMT/h4zzYJ7iJGofy/gzdktvfrGrCo+ O85CvI+P4DrU85S1vF5CcFHTOQiQrGpUWSkWNwykGT3/ARDAhKevapw7gpKCcxonBQzO1Uwe ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjxUC3fLFuIIO5l7Zvt3+90a1wax7S+cQiCq 1jHcvc7PFZfReTaG3YpHBmxJipUm4oFhmLT0AesojNugIm0ExR3g8d3ogSj30A/JUyR91N4P nFKL1hkPVLQtUNZaxwCe8dSY+8C3DLQxjLLGWOSG6XWZ3v+0i94qIfxY9FkN1CVKZ4vqfaqa 6xJm+w71RCCH4GIff+qaF2zg==
- Ironport-sdr: rt//dAaF0VRxbm3+uZiY7Gdgm23oFlGIo1jCA+1CZWUWDoT6MV24IKO0nIRGqDl7CLFAcvfhWx vmO89lMRY1ZJ5pDoDqYv8c6MougYskmtKo8H262Jxb98scu4+0rsGJmcXlp4RVP6fbbUSS5WBW hXV9TATCKu3U30tKK8GYpMHZRXnUjZAg0AvGzPuf9x0+SqMcq3Vm7dp+I2RInjVSGT+rdaw7Se qzDaJHiZGZ9pv3M/uHmJOrFq7HxhusUCbNTnvOiUcG+wg0l3Zrzb25yc2I5ap7iIbGOBFQ+CY3 UV0=
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Thread-index: AQHXcw9B8JOCMi7pNkCxw1Gex+9yXqs/vIGAgADZPpA=
- Thread-topic: [PATCH] Disable CONS debug logging
-----Original Message-----
From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of
Paul Durrant
Sent: Monday, July 12, 2021 8:09 PM
To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH] Disable CONS debug logging
[CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments
unless you have verified the sender and know the content is safe.
On 07/07/2021 09:54, Martin Harvey wrote:
> From: Owen Smith <owen.smith@xxxxxxxxxx>
>
a) Why?
Logging via the console ring does make the standard console access messier. You
can get interleaved output from logging and XenCons's TTY endpoint. The current
TTY endpoint should probably move to a secondary console ring.
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>
> ---
> src/xenbus/driver.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/xenbus/driver.c b/src/xenbus/driver.c index
> 1b621fa..f353a61 100644
> --- a/src/xenbus/driver.c
> +++ b/src/xenbus/driver.c
> @@ -58,10 +58,10 @@ typedef struct _XENBUS_DRIVER {
> static XENBUS_DRIVER Driver;
>
> #define XENBUS_DRIVER_TAG 'VIRD'
> -#define DEFAULT_CONSOLE_LOG_LEVEL (LOG_LEVEL_INFO | \
> - LOG_LEVEL_WARNING | \
> - LOG_LEVEL_ERROR | \
> - LOG_LEVEL_CRITICAL)
> +#define DEFAULT_CONSOLE_LOG_LEVEL 0 // (LOG_LEVEL_INFO | \
> + // LOG_LEVEL_WARNING | \
> + // LOG_LEVEL_ERROR | \
> + // LOG_LEVEL_CRITICAL)
b) Leaving code in comments like this is not something we want
If there is a reasonable justification for why we want no logging through the
console then ditch the comments.
Paul
The patch was originally written like this to avoid changing line numbers for
subsequent patches in the Citrix patch queue.
Patch should be reworked to remove the comments
Owen
>
> static FORCEINLINE PVOID
> __DriverAllocate(
>
|
