[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] Reduce logging of Fdo->NotDisableable
- To: "paul@xxxxxxx" <paul@xxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Owen Smith <owen.smith@xxxxxxxxxx>
- Date: Tue, 13 Jul 2021 08:13:42 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NoJ97vnXZ6HGj10QNdzFANlI8pTBATvULnZ5Rv/UKvg=; b=PC0Qp4JNJztpT8FcfO7BQMwSC93r5VHq1k1WKSpIrZWqlVyIjgkJzD6tJ2Wzov4Tnltzg0BsMgOtLTkmt9AufxHZG94x8BiYqqNDov2McRB7xN4BhfDyGHR5Qkyp+gW880YXeabRgBcEO2RrpFzNaWuic8cE0HwzwLsfG7rNMxeay1ZDkT2rJAtbFxgTgjlbgOk3350I1YoYYDUeTIxNSSvH2KY2KLNaFBfTHb7KQkDmeIliQietnU2NbaUSxH9I9Dk6fo0BeftaMAE30Sbj6anM3eXraTzc5eR7LX93zKFhaHmatZ6sfgg6S9BrqpuPTSQD3aJOyL2e8mupBX3B2g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RUa7xR5RL+jFPwGB/dk2X32cELftDfgvhVAqdSsZGEo4yipxCOEW8X7oMcUdUhoQUGg1xMukz5eTyu8JSer6XJ1GE35Od62GvWeajNJyRb6JkPgrbJ1jDDAFcfxMtxz9KF2ErotUPbZsaDzeuWiqy+WvUUckXiTZW8mgXvd2SdnPRWVGchpImJhZR0kjkyb0XFcXYC8xPJUGztPakJz0R5jT35g9tfsMNLhuO7eRlW1LWAjLdYChsgTJbxE3y8y7RkwP43pNqOf/NAX1jwiauOAEtJMkl2jwK/2rFXTsMjn1p/5Z6fPyYCzlySZV7ZJQx+FFIV2H4sbSTXZHyvutCA==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Delivery-date: Tue, 13 Jul 2021 08:13:53 +0000
- Ironport-hdrordr: A9a23:eaN2WK1OhhF9QUUouDVQuAqjBSFyeYIsimQD101hICG9Lfb2qy n+ppgmPEHP5Qr5AEtQ4+xoS5PwPE80kqQFrbX5XI3SETUO3VHHEGgM1/qF/9SNIVycygcZ79 YaT0EcMqy+MbEZt7eC3ODQKb9Jq7PnkJxAx92ut0uFJTsaMp2IhD0JbzpzZ3cGIzWucqBJcK Z0iPA3xQaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnX4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlVFtyssHfpWG1SYczBgNkHmpDr1L/sqq iJn/4UBbUx15oWRBDznfKi4Xin7N9k0Q6f9bbRuwqdnSW+fkNjNyMJv/MmTjLJr0Unp91yy6 RNwiaQsIdWFwrJmGDn68HPTAwCrDv8nZMOq59ls5Vka/ppVFaRl/1swGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlIhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OFDItTGyWSKEgjAQOGl3fa2sRE2AiaQu188HJpou WxbLpxjx9AR37T
- Ironport-sdr: i1sdk/wsu4shVUlMZUvYHNPg/JUrEzjqnl0VSck8q08XtFHiGpRCQUEag1l7H4051PF7KRbOQ5 GHFN17mGiiMNd3ZcpUvHpZTPpDYPEMIU7EFvgAdBOvyVVR6y7D97ZcNxonhNz0HXbm6RpP3imI vAb54zKdsMakLj//H1UlVjrhS6T6VVU6ShQaepYU8pOc4/O8chLeNxZSI2vmoGEKnwQtLUDX4j gH7njHuDbZfhBUjKrQhgiXcc3rOQMR3LM/z5W9WBpufyow8mzJ095aK0jlDPAVc1qGISBpIHek bqc=
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Thread-index: AQHXcw9ByxyQqunqYkSsOfMPiyPxWKs/vVOAgADZ6oA=
- Thread-topic: [PATCH] Reduce logging of Fdo->NotDisableable
-----Original Message-----
From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of
Paul Durrant
Sent: Monday, July 12, 2021 8:12 PM
To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH] Reduce logging of Fdo->NotDisableable
[CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments
unless you have verified the sender and know the content is safe.
On 07/07/2021 09:54, Martin Harvey wrote:
> From: Owen Smith <owen.smith@xxxxxxxxxx>
>
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>
Yes, it is probably unnecessary to log this at INFO level.
Acked-by: Paul Durrant <paul@xxxxxxx>
FYI, some 3rd party drivers can trigger Query PnP Device State far more often
than required, leading to considerable logging and possibly filling up
gigabytes of log files rapidly.
Owen
> ---
> src/xenbus/fdo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/xenbus/fdo.c b/src/xenbus/fdo.c index
> 03a71c0..b8f9c1a 100644
> --- a/src/xenbus/fdo.c
> +++ b/src/xenbus/fdo.c
> @@ -4530,7 +4530,7 @@ FdoQueryPnpDeviceState(
> goto done;
>
> if (Fdo->NotDisableable) {
> - Info("%s: not disableable\n", __FdoGetName(Fdo));
> + Trace("%s: not disableable\n", __FdoGetName(Fdo));
> State |= PNP_DEVICE_NOT_DISABLEABLE;
> }
>
>
|
