Re: [PATCH 1/3] Additional logging for module loading.

[Paul Durrant <xadimgnik@xxxxxxxxx>]

On 15/07/2021 14:15, Martin Harvey wrote:
> Recent releases of Windows (10 and 11 in particular) allow
> online edition updates which involve a driver migration step,
> which occurs in SAFEBOOT mode.
>
> In some rare cases, this step may fail (for a variety of reasons).
> This additional logging added to debug such upgrade cases.
Just to be clear here. Is the intention to have this logging enabled all 
the time or only in safe mode? The comment above suggests the latter but 
there is no such guard on the call to Info() below.
  Paul

> Signed-Off-By: Martin Harvey <martin.harvey@xxxxxxxxxx>
> ---
>   src/xen/module.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/src/xen/module.c b/src/xen/module.c
> index da7f113..1813e3b 100644
> --- a/src/xen/module.c
> +++ b/src/xen/module.c
> @@ -145,6 +145,11 @@ ModuleAdd(
>       BOOLEAN             After;
>       NTSTATUS            status;
>   
> +    Info("%p - %p [%s]\n",
> +         Start,
> +         Start + Size - 1,
> +         Name);
> +
>       New = __ModuleAllocate(sizeof (MODULE));
>   
>       status = STATUS_NO_MEMORY;