[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 2/6] Since Rx/Tx ring disconnects now no longer wait forever, we add some logging to catch those cases where the disconnect has timed out, indicating how many requests are still in the ring. This aids greatly with customer debugging.
- To: "paul@xxxxxxx" <paul@xxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Martin Harvey <martin.harvey@xxxxxxxxxx>
- Date: Thu, 22 Jul 2021 12:25:18 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1y5SUEpiJcK8jaCbzCwMLwu628UWzISVPMgeIIn6jgg=; b=JDZYQuTFgTPaAJo41TXBbONpZaI7+pvOVSfU/8haSW6U11r5gwgeoXC4KiwHuM9+jTsDht6x/fPHVzdH54oxXRSEUuRd0xgZRu9avI8hHCzU0JDYpuTwNhMz2xhLA1h0ry5Yxc/KaiFluFcfeyLmBtNt5v7c5XClryAI88O3ZsN2O5TB/laVcuGNvGH6FFQ/Dh8uXKczRcA7NgW6tH3zjq1jRNgIHbKiJ99iY0qlNTrC0UkOXTB6gZRhvhzvx4szkUgVJ0foz8d9rZiq5kzF6WzfB8QKIjL5sUPHJ6Q+cdv0H3AWWEKLHiBx3zaMX2aMjKFRptvpxvWckWlvNLw9pw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EpMauztoRiZoMd6789ng0FLEy5N39fiyQwuIniYc2ZH+YF/XyE00dj3i+EFgko0XYoDyWxnO8BR5yKjiVdp+2Dc3JQKyOL4/C9b/bRNWO8cw28uxe+laSvDi2JIZUqYG2FXrxpY2WlYQL64ja+Dh32C1Kd2LRcZNwXLJxo4Hj17V/6vqxDpI4eaJ2SwdJlLdbjgRllUGtfeZvTshN5F2s7Old8xz2nPA40qOqzBZYieLls4dDdv8Y82s/f/QvonfsKONDFbl59BoY/rsourgRJ0X25zWUE4ywHcK8Fgq1E1yCocw0RbecqGTIHgSAi60u7xQGoX1TTbmaKTy4SLubA==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Delivery-date: Thu, 22 Jul 2021 12:25:26 +0000
- Ironport-hdrordr: A9a23:82Xe7a/D0Dzs/H+FOABuk+AiI+orL9Y04lQ7vn2ZKSY5TiVXra CTdZUgpHvJYVMqMk3I9uruBEDtex3hHP1OkOws1NWZLWrbUQKTRekP0WKL+Vbd8kbFh4xgPM lbEpSXCLfLfCVHZcSR2njFLz73quP3j5xBho3lvglQpRkBUdAG0+/gYDzraXGfQmN9dPwEPa vZ3OVrjRy6d08aa8yqb0N1JdQq97Xw5evbiQdtPW9e1DWz
- Ironport-sdr: /ZPl10czxTPyL3l8+dlLj3ms+QOlhwkXhpzmwNM2xoMFBN68KkfzFTcR+uwQWfzMEqOe7rt+YW FgxCBA3So4Z+DnZIo1XRzj5LOlwywLe6amFHee7xnS3AxL3GiTcCI/PVvMkzSRNRb0ZJeEs1En w97A4PsBMgtY7sM5vFv6grLNlPKhKVGjdTJ/c2t2EsQyPnPE5Rrnv0Gg59O8PWs4micK9kUPYe EiSy6jCJ76rZgQOBhZA70zdNZoGJe2uB+yDU4HwIUk6lK6qgtHwyOEYzuZckPzARMUW5CeQduf Fc0hTbdg2nFcQNq0+VRFF+HV
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Thread-index: AQHXfWtkGU/pmVsFfkKcNK0c677mQKtNrBUAgAFCDBA=
- Thread-topic: [PATCH 2/6] Since Rx/Tx ring disconnects now no longer wait forever, we add some logging to catch those cases where the disconnect has timed out, indicating how many requests are still in the ring. This aids greatly with customer debugging.
-----Original Message-----
From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of
Paul Durrant
Sent: 21 July 2021 18:12
To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH 2/6] Since Rx/Tx ring disconnects now no longer wait
forever, we add some logging to catch those cases where the disconnect has
timed out, indicating how many requests are still in the ring. This aids
greatly with customer debugging.
> Did you consider triggering a debug dump (at least of the transmitter) rather
> than adding more ad-hoc logging?
We did that as well, but via various manual methods. I would not consider
upstreaming code that invokes a debug dump here given the changes in timeout.
MH.
|
