Re: [PATCH 2/6] Since Rx/Tx ring disconnects now no longer wait forever, we add some logging to catch those cases where the disconnect has timed out, indicating how many requests are still in the ring. This aids greatly with customer debugging.

[Paul Durrant <xadimgnik@xxxxxxxxx>]

On 22/07/2021 13:25, Martin Harvey wrote:
> -----Original Message-----
> From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of 
> Paul Durrant
> Sent: 21 July 2021 18:12
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH 2/6] Since Rx/Tx ring disconnects now no longer wait 
> forever, we add some logging to catch those cases where the disconnect has 
> timed out, indicating how many requests are still in the ring. This aids 
> greatly with customer debugging.
>
>
> > Did you consider triggering a debug dump (at least of the transmitter) rather 
> > than adding more ad-hoc logging?
> We did that as well, but via various manual methods. I would not consider 
> upstreaming code that invokes a debug dump here given the changes in timeout.
Why not. You can basically copy what TransmitterRingWatchdog() does, 
can't you? I.e. just call
XENBUS_DEBUG(Trigger,
             &Transmitter->DebugInterface,
             Ring->DebugCallback);

That should get you the logging you want, shouldn't it?

  Paul

> MH.