[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] Fix build with later WDKs


  • To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Paul Durrant <xadimgnik@xxxxxxxxx>
  • Date: Fri, 20 Aug 2021 09:00:06 +0100
  • Delivery-date: Fri, 20 Aug 2021 08:00:13 +0000
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

Sorry this has taken ages to get to...

On 10/08/2021 16:40, Owen Smith wrote:
- Adds alias for GetProjectInfoForReference target to version.vcxproj
     Later kits seemed to have renamed the build target, and will fail without
     this alias target.
- Adds "/fd sha256" to signtool command line
     WDK 20344 and later require binaries signed with a SHA256 file digest, or
     the build outputs are deleted
- Fixes warning 4061 - switch statement on enum types need to have a case for
     all values of the enumeration

IMO this is a stupid rule and, in many cases in the patch, leads to the magic 'number of things in the enum' being added to the case statements... which is just bogus. Let's just squash this warning instead.

  Paul



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.