[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 1/3] Fix build with later WDKs
- To: "paul@xxxxxxx" <paul@xxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Owen Smith <owen.smith@xxxxxxxxxx>
- Date: Tue, 31 Aug 2021 07:21:16 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cEgW+zWlNVo+oWof0tRwJFlWY6MdOWOJIurvvO4BiV8=; b=k9lV9h/eZaoyoGvNVfYpb/y3tFmvwBcsE2IfWVyOFS4tN5qL321M9md6DRNyRxe594abNo41fXTZwqJVDTPAiJKbiTQMn2DvrirYLWpgRuiqKC3/3RJPgEfft7JNHJ8eq/MPiemIn79RhoFZ/SdR5ScWHX1+Cxd69JGBsqd+5Z/CCcnHcRiL5xtqE/HlTLI69OEtyY2UCMh0O39b6H3LRnvKJyMT0s21MIi6qKyRQy6eKd91vyPhMLVsy69iHrT0miY/xzd+MD7pTdqEfdlSsg12N+j9pMA7sBLVq6xQUFpKiXvZu+fsE5uPvJJ/SnByI+EpwzIDUZHay4546UJtDg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KoEn5WyaCMDhrhEin+cLP7WprNBznzGL1j5B0gqX7Jv66oezkboFOFeMs6DT2ce2xYTSItrMstpuAPg1d2G+oIo5rFaFltP8sIuPRN61pHKHRrbz7cni+e/My1bQ3CS3tD965tD9v2Y2u5H4clBR5mYEvllC4AAXG2JZQsOPgUDzfNapaGGxlpfNCwrNUdC5MJnaa+k5n/3sb20S3MAw0yhCFhU/ZBypSDTMmwFeQOx+E+Gj6dNz9R5MOA6VoyUmadCqaESk25A+XXIP//1y0FlGMmTIyMJiH8ICwHkStF53OHYVAaTBJKfxYqvsIamMOAsHYu8SiLM6o5LgiAiJLw==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Delivery-date: Tue, 31 Aug 2021 07:21:30 +0000
- Ironport-hdrordr: A9a23:nZst2ag/Q8XFe1gxZ3BP9puc1XBQX2913DAbv31ZSRFFG/FwyP rAoB1L73PJYWgqNU3IwerwQpVoMkmsiKKdhrNhcotKPTOW9FdASbsN0WKM+UyHJ8STzJ8/6U 4kSdkENDSSNyk1sS+Z2njALz9I+rDum8rI5ds2jU0dNT2CA5sQtzuRYTzrd3GeMTM2YqbRY6 DsgvavyQDQG0g/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZebxp/hZMZtU TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESttu/oXvUjZ1SxhkFxnAid0idvrD AKmWZmAy1H0QKSQohym2qq5+Cv6kd215ao8y7lvZKqm72HeNt9MbsbuWsRSGqm12Mw+N57y6 5FxGSfqt5eCg7Bhj3045zSWwhtjVfcmwtrrQc/tQ0obWIlUs4ZkWXfxjImLL4QWCbhrIw3Gu hnC8/RoP5QbFOBdnjc+m1i2salUHg/FgqPBhFqgL3e7xFG2HRii0cIzs0WmXkNsJo7Vplf/u zBdqBljqtHQMMaZb90QO0BXcy0AGrQRg+kChPYHX33UKUcf37doZ/+57s4oOmsZZwT1ZM33I /MVVtJ3FRCDH4Gyff+qKGj1yq9DVlVcQ6duv221qIJz4EUHoCbQBFrYGpe4Pednw==
- Ironport-sdr: TIOuCVSo9rFeImUHdeZUdSllpWnoRjjvTGLZmk/CwBbIWmoep3YkemnGPaqyLouN/dQEVtNpZL MA2Nq3x56+NBBkau1zsOoTTRMlz4GmOcHRUEBt0W6PpTX6QUWJuC97ijSlEcyM1558Fzqab01J 4sM0VItRvFPHLTrPTOdCbnFuUs9ELXnREJZfSTfg1TDTGJVCv1UlbxiaWPdFoyMd4owuyACZ2i Mbs8V5GdP/jTpGQewi92bJFUrOQM3yl+uEBB21jTUzXUOQTRbm7qawdNFLjhHwr0bByLnrwVTI M3zCRc8EGgD6SXsWMakXJqfL
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Thread-index: AQHXjf4eOE+nzN9Is0qjWQXuw3BBZat8FsoAgBE+MsA=
- Thread-topic: [PATCH 1/3] Fix build with later WDKs
-----Original Message-----
From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of
Paul Durrant
Sent: Friday, August 20, 2021 9:00 AM
To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH 1/3] Fix build with later WDKs
[CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments
unless you have verified the sender and know the content is safe.
Sorry this has taken ages to get to...
On 10/08/2021 16:40, Owen Smith wrote:
> - Adds alias for GetProjectInfoForReference target to version.vcxproj
> Later kits seemed to have renamed the build target, and will fail without
> this alias target.
> - Adds "/fd sha256" to signtool command line
> WDK 20344 and later require binaries signed with a SHA256 file digest, or
> the build outputs are deleted
> - Fixes warning 4061 - switch statement on enum types need to have a case for
> all values of the enumeration
IMO this is a stupid rule and, in many cases in the patch, leads to the magic
'number of things in the enum' being added to the case statements... which is
just bogus. Let's just squash this warning instead.
Paul
Suppressing the warning is better. Fixing the switch statements didn’t seem so
large, until I got to xenvbd - I squashed the warning here, as I don’t have
enough time to fix every switch statement that’s missing multiple redundant
case labels (IIRC, some were 20+ missing case labels)
Owen
|
