[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] Fix div by zero in xenvif if no queues.
- To: Martin Harvey <martin.harvey@xxxxxxxxxx>, "paul@xxxxxxx" <paul@xxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Martin Harvey <martin.harvey@xxxxxxxxxx>
- Date: Mon, 21 Mar 2022 16:45:39 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F4alCZBJuj8d647rUjVEyU2RTvnKjVVjKBrCY8LD6Hw=; b=VRi7nlIsUBj6uP2svDFVt5uXSoLtIVdR23vLT6bDCgSb8LF6cA+028P73T3xLy2ifjvYGue4jb2QngdnKag5KJv135q9Wd5hFZ1y9fGxDW9TyrULB5QYW3Win9XqkSuSjnp5kS85wBwtm7DfgaZKSybZ1inQTy7c/aFTRbHge057SHFINDgGSUGu1aKiLIVJdPF7KB1UjR+NqMZya0EXFniVQ0KT3e53CQiwdUOXOa6Jf+bP+OjbaX+YnFQ00aKMNpfDAxTPjiMjBvdDkOhTw+tf48VOK+beN4lOd18/37Vtf80euheAWvqk8bDCemHrC0vBVLAbcR+YezXwymz5Lg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bl97DUh0xPuzldJ6WluQawT2e8c134E1oQMImUrEGJKng2cfLJw7wwC1HLc3/NzlUsU7frVUVRf5TqwpAshnQZDUCY8+hhIqo+CY6CknsRxdcNcF3VKx+46b6DxVPdKhzWewxy3+ww2Go4o+XaLvcFXGwBWBew8GeARUPu6kWvdEh8kkCQpcaIX4Gxu+u0wPVlOmPxI851tKhtqDScv1Nw0d+eBGceVQv5PgwYFBe9Ap2Nzhz+nmwgYi/hjkBO2SCABRXl8xWHHDEMwH/a/ruyaf63NUdlNXbNb2V6ja5TIY4GKZ6qTa8SyYDAT2nK+fPASn5kA31/pahIn4Vn/T7g==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Delivery-date: Mon, 21 Mar 2022 16:45:48 +0000
- Ironport-data: A9a23:BbZD2K6SwkKgE+NJRNxQ1gxRtEHHchMFZxGqfqrLsTDasY5as4F+v mdOXWzSM/yONmWhett3YI7jp0ME7JDcnIRjHgM4/i9gHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YPjWlvX0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSOalYQEZ/+vN1MdAhDHDl4GqhWo6TudC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsas2t8zDefDf88X53Sa67L+cVZzHE7gcUm8fP2O ZRGOGI2NkqojxtnClstIbEgvO2UiDraeBNKt3zSvYwW7D2GpOB2+Oe0a4eEEjCQfu1Kn0Ddv nyD82nnDxUyMN2E1SHD4n+qnvXIny7wRMQVDrLQ3uZjnVm71mEVThoMWjOGTeKR0xDkHYgFc gpNp3Ro/fNaGFGXosfVYT7pmVG2jDolCv1BCOIi7iaI2vHPylPMboQbdQJpZNsjvc4wYDUl0 F6Vgt/kbQBSXK2ppWG1renN827rUcQBBSpbPHJfE1NZizX2iNtr5i8jWOqPB0JcYjfdPTjri w6HoyEl71n4pZ5ajv7rlbwrbt/Fm3QocuLXzliMNo5GxlkgDGJAW2BPwQKHhcus1K7DEjG8U IEswqByFtwmA5CXjzCqS+4QBryv7PvtGGSC3QE/RsF4rmT0oC/LkWVsDNZWfhoBDyr5UWWxP B+7Vf15uve/w0dGnYcoOtnsWqzGPIDrFMj/V+C8Uza9SsMZSeNzxwk3PRT49zm0yCAEyPhjU b/GIZfEJStLUsxPkWvpL9rxJJd2n0jSM0uIHsulp/lmuJLDDEOopUAtawLfMLpmsPva/G04M b93bqO39vmWa8WnCgH/+o8PN1Eaa389AJH9sctMceCfZAFhHQkc5zX5mNvNp6QNc3xpq9r1
- Ironport-hdrordr: A9a23:gVKjvqk6xxYBymso2M63duN8MQrpDfIo3DAbv31ZSRFFG/Fw8P re+8jztCWE7Ar5PUtKpTnuAsW9qB/nmqKdgrNwAV7BZmfbUQKTRekJgLcKqAeAJwTOssJbyK d8Y+xfJbTLfD1HZB/BkWqF+gAbsbu6zJw=
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Thread-index: AQHYOHVErur6M9Oay0m6lfwVxs2ql6zG/w8AgAMM6lCAAAji0A==
- Thread-topic: [PATCH] Fix div by zero in xenvif if no queues.
-----Original Message-----
From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of
Durrant, Paul
> It really should not happen at all.
I also notice, with some trepidation, that FrontendSetNumQueues does:
status = XENBUS_STORE(Read,
&Frontend->StoreInterface,
NULL,
__FrontendGetBackendPath(Frontend),
"multi-queue-max-queues",
&Buffer);
if (NT_SUCCESS(status)) {
BackendMaxQueues = (ULONG)strtoul(Buffer, NULL, 10);
So in the case where the contents of our xenstore buffer is not an integer,
we'll set backend max queues (and hence frontend max queues) to zero, without
so much of a whimper of an error, so that prob needs to be sorted too.
MH.
|
