[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] Improve Xenfilt power and default IRP handling.
- To: "paul@xxxxxxx" <paul@xxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Martin Harvey <martin.harvey@xxxxxxxxxx>
- Date: Tue, 22 Mar 2022 14:32:04 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O7HVVwU+oR5cUWmtukEWyAt0rOnONIdXL1SWupmyrag=; b=dLiAr19HsUtofBGFnY8R3nVkZ8SgmPxFN65VuBVUDa1dtlN7mNwyKCeC6QkRrAXRKHfushWsFqohJyi865Jn+hRxTc67mAzC0/5IGB/7k45bgAe1khfJZw2ejCD/DF9FImyNrh5Az6E502ZlG2Gl8ehDIt8bsTj/T051qPf32Ed9DXcOzSgBw1Ya7oZFHNejPgQQqtIsUF9dh9uBGt8EcsbB6EihnsXKk0h2fL2F9RI7rAgZSkvToxXQ+6105sRQT/e6Ax7RgyIIh/Epw19rfAyvaD5SyyBcSWrsBD6dNPiguTMnoElLVGU4u0ghntx9233ocCVcjavBup4/zFLl5w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CQO9n4hqU8ViFFc7xknLj/YN8jt0qcu6rbhWS4fB3MiU68sQGvOZKhKi7nUf42rcn0JHzEKVO4S4iJvLjyLhScK8cGPna7Zy/nQZOVpdy0MjCIYj00PMzypzmXzYl8wNO4e7e793ZTLIlQZ/NxiFZK5KKvduk1mm8JKcC4P2ANoQXaK5xmolJImh6JhY+5JioyvFQdqWz8NxKu/8tp9lBmh/kuzlQaLMIi6QHk1W+iDwAaewRptRP13kuFrc25bDm6QlnzmakTgKFnLdEU3mleoVBqGW2K1ZTLJV3is/2VEZHBNwc6E9Jnww17hGiWa75aNuOjDAKfFb43aIqve0yA==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Delivery-date: Tue, 22 Mar 2022 14:32:37 +0000
- Ironport-data: A9a23:iCxe1KrsgjO1pB8dDF+qlAFVcLZeBmIUZRIvgKrLsJaIsI4StFCzt garIBnXb6rbZ2f1KIpyOY3g8B5XucDcx4dlTws4/ithQypE8ZuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvW4 4mq+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBE4nGhsQMbThkLDhTB69c2ebWHkSfiJnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/ vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVIyDjDEfcgB5DKWbvH9PdT3Ssqh9AIFvHbD yYcQWQxPEqdPEUWUrsRIIARkuqxlyLESiZntnXFvZdq80bv0AMkhdABN/KKI4fXFK25hH2wu WPAunznRx0XKtGb4T6E6W63wP/CmzvhX4AfH6H+8eRl6HWLz3EXIA0bUx28u/bRt6Klc4sBc QpOoHNo9PVsshzwJjXgY/GmiFOgtAA8SuRxL9IjxTuP0IuN8jmlJlFRG1atd+canMMxQDUr0 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqVFr5e/LiJYsoZ8N0a6 xSDt2AAiroalqbnPI3rrAmc01pASnUkJzPZBzk7vEr4t2uVh6b/PuREDGQ3C94ad+51qXHb4 BA5dzC2trxmMH10vHXlrB8xNL+o/e2ZFzbXnERiGZIsnxz0pSL8LdAPvW4vfhk0WirhRdMPS BWP0e+2zMUOVEZGkIctO97hYyjU5faI+SvZugD8MYMVP8kZmP6v9yByf0+At10BY2B3+ZzTz ayzKJ72ZV5DUPwP5GPvG481jO96rghjlDi7bc2qkHyaPU+2OSf9pUEtawDVMIjULcqs/W3oz jqoH5DTmksFD7GmPHW/HEx6BQliEEXXzKve8qR/XuWCPhBnCCcmDfrQyqkmYItrg+JekeKgw 513chYCoLYjrRUr8Tm3V00=
- Ironport-hdrordr: A9a23:dvaFHaosXlMZIaA/lvBlMTYaV5uQL9V00zEX/kB9WHVpm5Oj+f xGzc516farslossSkb6K290dq7MA/hHPlOkMUs1NaZLUTbUQ6TTb2KgrGSugEIdxeOlNK1kJ 0QCZSWa+eAQmSS7/yKmDVQeuxIqLLsncDY5ts2jU0dNj2CA5sQtjuRYTzrdnGeMTM2Y6bRY6 DsgfavyQDQHEg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZRbxp/hZMZtU TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESstu/oXvUgZ1SxhkF2nAid0idurD AKmWZlAy1H0QKTQohym2qr5+Cv6kdp15ao8y7mvZKqm72GeNt9MbsYuWsRSGqp12Mw+N57y6 5FxGSfqt5eCg7Bhj3045zSWwhtjVfcmwtrrQc/tQ0obWIlUs4ZkWXfxjIhLL4QWCbhrIw3Gu hnC8/RoP5QbFOBdnjc+m1i2salUHg/FgqPBhFqgL3e7xFG2HRii0cIzs0WmXkNsJo7Vplf/u zBdqBljqtHQMMaZb90QO0BXcy0AGrQRg+kChPYHX33UKUcf37doZ/+57s4oOmsZZwT1ZM33I /MVVtJ3FRCDH4Gyff+qKGj3iq9M1lVBw6duv22z6IJyIHBeA==
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Thread-index: AQHYN8VWdc48nzMGh0e89v1joYTp56zLdi4AgAAMNxA=
- Thread-topic: [PATCH] Improve Xenfilt power and default IRP handling.
-----Original Message-----
From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of
Durrant, Paul
Sent: 22 March 2022 13:44
To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH] Improve Xenfilt power and default IRP handling.
> This is a very large patch given absolutely no explanation. It really
> needs a *much* more comprehensive commit comment... even be broken down
> into multiple incremental patches, e.g. maybe doing FDO and PDO separately.
OK. That's fine. I need to write a long explanation as to
- Why synchronously sending IRP's down with a completion routine is causing
problems.
- Why we should process asynchronously and skip stack locations.
- What set of bugchecks this fixes.
- I also need to re-whql it...
- and Owen wants to remove the "Strategy" Enum and re-work the code so it's in
a more consistent style...
So we can get back to this in a bit, and it'll prob be re-worked. Slightly
kamikaze patch submit, just so you could get a sneak peek.
MH.
|
