Re: [PATCH] Improve Xenfilt power and default IRP handling.

["Durrant, Paul" <xadimgnik@xxxxxxxxx>]

On 22/03/2022 15:32, Martin Harvey wrote:
> -----Original Message-----
> From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of 
> Durrant, Paul
> Sent: 22 March 2022 13:44
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH] Improve Xenfilt power and default IRP handling.
>
>
> > This is a very large patch given absolutely no explanation. It really
> > needs a *much* more comprehensive commit comment... even be broken down
> > into multiple incremental patches, e.g. maybe doing FDO and PDO separately.
> OK. That's fine. I need to write a long explanation as to
>
> - Why synchronously sending IRP's down with a completion routine is causing 
> problems.
> - Why we should process asynchronously and skip stack locations.
> - What set of bugchecks this fixes.
Yes, that will make it easier for someone looking back on this to see 
what the fundamental changes were motivated by and how they made things 
better.
> - I also need to re-whql it...
> - and Owen wants to remove the "Strategy" Enum and re-work the code so it's in 
> a more consistent style...
Ok. FWIW I don't think the strategy thing is necessarily a bad idea; I 
think we really just need some better names. If there is another way 
e.g. using function pointers, then that may be neater.
> So we can get back to this in a bit, and it'll prob be re-worked. Slightly 
> kamikaze patch submit, just so you could get a sneak peek.
Well, thanks for the heads up then. Perhaps mark the patch RFC next time 
if you're not really expecting it to be committed? :-)
  Paul