RE: [PATCH] Refactor Wmi.c

["Durrant, Paul" <pdurrant@xxxxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of 
> Owen Smith
> Sent: 30 March 2022 10:32
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> Subject: [EXTERNAL] [PATCH] Refactor Wmi.c
> 
> CAUTION: This email originated from outside of the organization. Do not click 
> links or open
> attachments unless you can confirm the sender and know the content is safe.
> 
> 
> 
> * Moves functions to be in related locations in file
> * Formats code to appropriate code style
> * Inlines some functions that are only called from 1 location
> * Uses LIST_ENTRY macros to access linked lists
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>
> ---
>  src/xeniface/wmi.c | 3794 ++++++++++++++++++++++----------------------
>  1 file changed, 1907 insertions(+), 1887 deletions(-)

Eek. 3794 lines of change! That's almost impossible to review. Is there any 
chance you can break this down?

  Paul