[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] Refactor Wmi.c
- To: "Durrant, Paul" <pdurrant@xxxxxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Owen Smith <owen.smith@xxxxxxxxxx>
- Date: Wed, 30 Mar 2022 10:07:28 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pNxCy6LewsGWH/okj4jZNbhHePucaaWH+8bUmBsMdTc=; b=jCH4mjj8YvNdfsWMOcdlrnzh9TS9AkcMsv/Kr4YqF0kgrNp4CPG+B416SKtATEdMxcgPZrKaBIqmSIevQcU8qDtUyLkMLKiRuosn2OcJKyWxJ3BT/1OpZxLTFFZSssnTyl6kxwyjRadj/k3gA7NdTDjodq+01opjosGQcEG6bHI6+Bg+W13InYgkv5kr7BDd8OS1w6MPKWSryEilltkS3cVF1Mm8pp7hvd51LDRwfHeUe4bOo3qpKbDHQfKTDZVrP76EVGNVtWozgk3QFNyYnX84zWzHX87PETlyJtUvHUqG3e8ybq8FBnMy9B6h3M7SBFaMGBqIEOrT2OHa6WX+vw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E5dgTgOhHHIjcFgFaTWHjnntCPdZfojHjYX789rwO/rQF1EfOqGpdxI7ChNzYMwjyT0DRDx1nTVtW67QJU2mlMXm8AiKx3YVvgS2bW3Q0XXSZorYzbaNbBWLV9JIv5KOEN7GUprASPwWmkiLqxNKJ0EO0afhKRkfD835aBn5a81lEsUPrXD5k2V4Ck1c5XIt9J1iySqhEwCOjxl8RNLECwuQ7ZKAaTuef62qi20cpx9hLWtQWyGq4bmgr1gLrbuXkOMcVVgu/kHNJetcT9BPi06/0etvlc8go4Twe5EU4F8l/kViW6KpXQqoyX/NylV4ymdMw7VxVxsoDhwo8OxGZQ==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Delivery-date: Wed, 30 Mar 2022 10:07:41 +0000
- Ironport-data: A9a23:QVlRlqozmSf66K2d0Ggk88iDQWpeBmIQZRIvgKrLsJaIsI4StFCzt garIBmDO/yINjP0LYt2YYq39RhTvMfXnINhGgZtq3hhHylE85uZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrZRbrJA24DjWVvW4 ouq+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBLvWUlN0zCzBkCTBdHIIb/I74AH/giJnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/ vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVIyi7UC7A9RJHfQ43B5MNC3Sd2jcdLdRrbT 5RIOGI+MU2ZC/FJEggSNLExvMXvvVXQbwdbpQukh/s+6UGGmWSd15CyaYGIK7RmX/59gUee4 3rYumj0HBweHNie0iaetGKhgPfVmiH2U55UE6e3ntZyjECJ3GUVFDUfUFKppv//gUn4RtE3F qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc8oIS+EDxlmk9rDFwCe2W2w1cR9GN+Vz4afaWgcW/ lOOmtroAxlmv7uUVW+R+9+okN+iBcQGBTRcPHFZFGPp9/Gm+dhu1UyXEr6PBYbv1rXI9SfML ydmRcTUr5EaloY12qqy5jgraBr898GSHmbZCug6N19JDz+Vhqb4P+RECnCBtJ6sybp1qHHb5 hDofODEsYgz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvm0ueRcza5xcI2e1C KM2he+3zMUJVJdNRfUqC79d9uxwlfSwfTgbfq68giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy r/AGftA+U0yUPw9pBLvHr91+eZymkgWmDOCLbimnk/P+efPOxaopUItbQLmghYRt/jf/m04M r93aqO39vmoeLCnOnCMq99Kdzjn7xETXPjLliCeTcbaSiJOE2A9Ef7Bh7Qnfo1uhaNOkenUu Hq6XydlJJDX3BUr9S3ihqhfVY7S
- Ironport-hdrordr: A9a23:YVG9PajJJYoLF/D844LgdWm71XBQX2N13DAbv31ZSRFFG/FwyP rAoB1L73PJYWgqNU3IwerwQpVoMkmsiKKdhrNhcItKPTOW8ldASbsN0WKM+UyHJ8STzJ8/6U 4kSdkENDSSNyk3sS+Z2njALz9I+rDum8rI5ds2jU0dNT2CA5sQqTuRYTzrd3GeMTM2YqbRY6 DsgvavyQDQG0g/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZQbxp/hZMZtU TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESjtu/oXvUhZ1SxhkF3nAid0idprD AKmWZkAy1H0QKQQohym2qo5+Cv6kdo15ao8y7lvZKqm72HeNt9MbsZuWsRSGqm12Mw+N57y6 5FxGSfqt5eCg7Bhj3045zSWwhtjVfcmwtqrQc/tQ0pbWIlUs4mkWXfxjImLL4QWCbhrIw3Gu hnC8/RoP5QbFOBdnjc+m1i2salUHg/FgqPBhFqgL3f7xFG2HRii0cIzs0WmXkNsJo7Vplf/u zBdqBljqtHQMMaZb90QO0BXcy0AGrQRg+kChPbHX33UKUcf37doZ/+57s4oOmsZZwT1ZM33I /MVVtJ3FRCD34Gyff+qaGj3iq9MFlVBw6du/22z6IJyYHBeA==
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Thread-index: AQHYRBktznavb3WZD0a/Bmx10iJtaKzXq+kAgAAHLmA=
- Thread-topic: [PATCH] Refactor Wmi.c
-----Original Message-----
From: Durrant, Paul <pdurrant@xxxxxxxxxxxx>
Sent: 30 March 2022 10:40
To: Owen Smith <owen.smith@xxxxxxxxxx>; win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Subject: RE: [PATCH] Refactor Wmi.c
[CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments
unless you have verified the sender and know the content is safe.
> -----Original Message-----
> From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On
> Behalf Of Owen Smith
> Sent: 30 March 2022 10:32
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> Subject: [EXTERNAL] [PATCH] Refactor Wmi.c
>
> CAUTION: This email originated from outside of the organization. Do
> not click links or open attachments unless you can confirm the sender and
> know the content is safe.
>
>
>
> * Moves functions to be in related locations in file
> * Formats code to appropriate code style
> * Inlines some functions that are only called from 1 location
> * Uses LIST_ENTRY macros to access linked lists
>
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>
> ---
> src/xeniface/wmi.c | 3794
> ++++++++++++++++++++++----------------------
> 1 file changed, 1907 insertions(+), 1887 deletions(-)
Eek. 3794 lines of change! That's almost impossible to review. Is there any
chance you can break this down?
Paul
Its not easy to break down a refactor like this, 1 small change has many knock
on changes throughout the file.
Its probably easier to apply locally and compare side by side, but I'm not
expecting this to be an easy or quick review - I probably should have posted
1st with RFC
Owen
|
