[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] Use STATUS_PNP_REBOOT_REQUIRED in IRP_MN_START_DEVICE when a reboot is required
- To: Owen Smith <owen.smith@xxxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Owen Smith <owen.smith@xxxxxxxxxx>
- Date: Tue, 12 Apr 2022 07:13:50 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tcV1tTyk7aKvhzrSqJ9pOEClXf2LjuQsfbyMKx6iWVg=; b=PQ0q9seIHS7kDFLfFdBnGDzdp+Ep64zmuFTi1QptL3BJZ6HePUj4wu41f8bQwMqqJU+hK/YFfF3Y84L0UNBiRzld8YzyMxViHbpUOchhaLHcv7ekQkP0Fol7VsorO71qsvhzmoG2CU5MdQoFwC6Ikg+hAdKSO6U/NGUV87BORni2ktwL1R/byoDRmHdPqUidxZ2GOEHE7aefs83sVHU+Gga4xZ1I3bQOw9Wo+e+JMNnz38KrD2+lCRIoL74FaWEOnnJaX59k8I/bdkMkVONzHBKaHm/rpEj3/V2uTh/Q3xkjbM20RBrZlQEtke1MrI0OlLYnNk3bPLFhE1B1GFRERA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EaUReirPHmHQt20oqJN4gVPMHS6jwV2KCiFBOpeSE6OB2sbHRrbc9hgPXc9QVH3g/niwvaoMz4GWgWHKba/2Rgqd6kx2qIvHLY0XwLzk6EFIkyLVaAzmukoZObiXswOJ8dTs/CwPj7Z0nPYvlHJfJI/PjizIFLeH7Ph7erYUfSxCamp4yylm8QDx9sXwOpLDXXXa2VQMxqWmVNOZZSXkPNW5C/h9+ikU1wB0VMiyJwkjeiVum4TPFtW/cB4l/gB5RCrGcl16hJTQsYWkHa0715ykcCzXXxEgg0xXRI932QpciX9RdGBA2MpAAkmCFmo2MtTA7FuMTPb6YCnz1mt3Ow==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Delivery-date: Tue, 12 Apr 2022 07:14:05 +0000
- Ironport-data: A9a23:E52D6aLVijA+h4g1FE+Ro5UlxSXFcZb7ZxGr2PjKsXjdYENS3mMAz 2YeUWnQb6mNNGKnKosgbNi1oBsGsJXSz94yGQZlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh3tcy2YHR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 I1xrYzzeDswB5/dubkHUglZLnx8NIQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq 6ZecmpUKEne2aTmm9pXScE17ignBM70MYVZoXRh0THxBvc6W5HTBa7N4Le02R9u1p4QRq2CN qL1bxJgVTmbaBF+Z20NUpE1neOPtCT5QThh/Qf9Sa0fvDGIkV0ZPKLWGMXUfJmSW4BZk1iVo krC/n/lGVcKOdqH0z2H/3mwwOjVkkvGtJk6TePisKQw2RvKmzJVWEZ+uUaHTeeR0nKmS5FuF 1UtyDsP8LIz5E2WE9v0dkjtyJKbhSI0V91VGuw8zQiCzKvI/gqUblQ5oi59hM8O75FvG2Fzv rOdt5awXGE07uXJIZ6I3u3MxQ5eLxT5OoPricUsaQIeq+fur4go5v4kZoYySfXl5jEZ9NyZ/ txrkMTcr+hL5SLo///ilbwiv95KjsKXJuLSzl+KNl9JFisjOOaYi3WAsDA3F8poIoeDVUWmt 3MZgcWY5+1mJcjTyH3SGLRdTOj0vavt3NjgbbhHRcZJG9OFoSDLQGytyGsmeBcB3jgsJFcFn 3M/SSsOvcQObRNGnId8Yp6rCtRC8EQTPY+NaxwgVfIXOsIZXFbepElGPBfMt0iwwBlEufxuY v+zLJfzZUv2/Iw6lVJasc9GiuR1rs3/rEuOLa3GI+OPjeLFNCHIE+9cWLZMB8hghJ65TMzu2 483H+OByglFUf24ZS/S8IUJKksNI2R9Dpfzw/G7vMbZeGKKxElJ5yft/I4c
- Ironport-hdrordr: A9a23:FOTom6FflDTU7CDbpLqFU5HXdLJyesId70hD6qkvc3Jom52j+P xGws526fatskdtZJhSo6H9BEDmewKRyXcV2/hdAV7GZmjbUQSTXfhfBOfZsl/d8mjFh5RgPM RbAudD4b/LfCBHZK/BiWHSebtBsbq6GeKT9JzjJh9WPFhXgspbnmNE43OgYytLrX59dP0E/f Snl696jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKXSSw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8y/T9aw+cyjpAVr4RGYFqjwpF5d1HL2xa1O Ukli1QfPibLUmhOV1d7yGdnTUImwxelEMKgWXo/0cL5/aJHA7SQvAx9L5xY1/X7VEts8p717 8O12WFt4BPBReFhyjl4cPUPisa3nZcjEBS59L7tUYvGLf2qYUh2LA37QdQCtMNDSj64IcoHK 1nC9zd/u9fdRefY2rCtmdizdSwVjBrdy32CHQqq4iQyXxbjXp5x0wXyIgWmWoB7os0T91B6/ 7fOqplmblSRosdbL57Bu0GXcyrY1a9Ci7kISaXOxDqBasHM3XCp9r+56g0/vijfNgSwJ47iP 36ISRlXK4JCjbT4OG1re52G0r2MRWAtBzWu7Nj26Q=
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Thread-index: AQHYPS83dn50NOlgFEW8U3SgHt6yKazr/0kQ
- Thread-topic: [PATCH] Use STATUS_PNP_REBOOT_REQUIRED in IRP_MN_START_DEVICE when a reboot is required
-----Original Message-----
From: Owen Smith <owen.smith@xxxxxxxxxx>
Sent: 21 March 2022 14:23
To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Cc: Owen Smith <owen.smith@xxxxxxxxxx>
Subject: [PATCH] Use STATUS_PNP_REBOOT_REQUIRED in IRP_MN_START_DEVICE when a
reboot is required
Failing IRP_MN_START_DEVICE can lead to WHQL distribution of drivers to be
rejected by MS, as too many VMs in the gradual rollout phase will report this
error on update. Using STATUS_PNP_REBOOT_REQUIRED will indicate that the VM
requires a reboot, and should not be treated as a gating factor (it should also
trigger the Windows Update process to report the reboot to users and/or trigger
an automatic reboot)
Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>
---
src/xenvif/pdo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/xenvif/pdo.c b/src/xenvif/pdo.c index bc9b9ed..b3a4aae 100644
--- a/src/xenvif/pdo.c
+++ b/src/xenvif/pdo.c
@@ -1303,7 +1303,7 @@ PdoStartDevice(
if (Pdo->HasAlias) {
PdoUnplugRequest(Pdo, TRUE);
- status = STATUS_UNSUCCESSFUL;
+ status = STATUS_PNP_REBOOT_REQUIRED;
goto fail9;
}
--
2.33.0.windows.2
|
