Re: [PATCH] Use STATUS_PNP_REBOOT_REQUIRED in IRP_MN_START_DEVICE when a reboot is required

["Durrant, Paul" <xadimgnik@xxxxxxxxx>]

On 21/03/2022 14:23, Owen Smith wrote:
> Failing IRP_MN_START_DEVICE can lead to WHQL distribution of drivers to be
> rejected by MS, as too many VMs in the gradual rollout phase will report this
> error on update. Using STATUS_PNP_REBOOT_REQUIRED will indicate that the VM
> requires a reboot, and should not be treated as a gating factor (it should also
> trigger the Windows Update process to report the reboot to users and/or trigger
> an automatic reboot)
>
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>
Acked-by: Paul Durrant <paul@xxxxxxx>

> ---
>   src/xenvif/pdo.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/xenvif/pdo.c b/src/xenvif/pdo.c
> index bc9b9ed..b3a4aae 100644
> --- a/src/xenvif/pdo.c
> +++ b/src/xenvif/pdo.c
> @@ -1303,7 +1303,7 @@ PdoStartDevice(
>       if (Pdo->HasAlias) {
>           PdoUnplugRequest(Pdo, TRUE);
>   
> -        status = STATUS_UNSUCCESSFUL;
> +        status = STATUS_PNP_REBOOT_REQUIRED;
>           goto fail9;
>       }
>